Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM NFT section #15467

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

EVM NFT section #15467

wants to merge 10 commits into from

Conversation

enjojoy
Copy link
Contributor

@enjojoy enjojoy commented Nov 20, 2024

Description

New section is introduces, enabled through experimental features.
TODO: check copy of EF desc with Ben
TODO: add scroll shadow when the navigation doesnt fit
-desc: no pics

Related Issue

Resolve #8004
Resolve #12165 (last issue)

Screenshots:

In experimental features:

image

@enjojoy enjojoy force-pushed the feat/nft-section branch 2 times, most recently from 92e75fd to 4b72ec9 Compare November 21, 2024 12:51
@tomasklim tomasklim assigned tomasklim and unassigned tomasklim Nov 22, 2024
@enjojoy enjojoy force-pushed the feat/nft-section branch 3 times, most recently from 7a926bb to 13d1ed5 Compare November 22, 2024 14:28
packages/suite/src/views/wallet/nfts/ShownNfts.tsx Outdated Show resolved Hide resolved
packages/suite/src/views/wallet/nfts/NftsTable/NftsRow.tsx Outdated Show resolved Hide resolved
packages/suite/src/views/wallet/nfts/NftsNavigation.tsx Outdated Show resolved Hide resolved
packages/suite/src/utils/wallet/nftUtils.ts Outdated Show resolved Hide resolved
Copy link
Member

@tomasklim tomasklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that this is just a PR draft, but I would like to avoid duplicating code and making additional changes later.

@enjojoy enjojoy force-pushed the feat/nft-section branch 7 times, most recently from 1478947 to 1368894 Compare December 3, 2024 12:19
@enjojoy
Copy link
Contributor Author

enjojoy commented Dec 3, 2024

I understand that this is just a PR draft, but I would like to avoid duplicating code and making additional changes later.

I appreciate this approach

@enjojoy enjojoy force-pushed the feat/nft-section branch 2 times, most recently from fc7faee to deb7eaf Compare December 3, 2024 18:37
@trezor trezor deleted a comment from github-actions bot Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 20
  • More info

Learn more about 𝝠 Expo Github Action

@enjojoy enjojoy force-pushed the feat/nft-section branch 4 times, most recently from f1df078 to 3389b4c Compare December 4, 2024 13:52
@enjojoy enjojoy changed the title feat(suite): nft section EVM NFT section Dec 4, 2024
@enjojoy enjojoy force-pushed the feat/nft-section branch 4 times, most recently from 2126a8d to 7168672 Compare December 12, 2024 09:14
@tomasklim tomasklim self-requested a review December 12, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EVM tokens NFTs section
2 participants