Display all tokens in a multitoken tx #15457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enjojoy
force-pushed
the
feat/display-multitoken-tx
branch
3 times, most recently
from
370e3f8 to
f3c2060
Compare
|
@qa there are ERC-1155 transactions with multitokens on academic seed "v" passphrase on polygon and Ethereum Sepolia |
enjojoy
force-pushed
the
feat/display-multitoken-tx
branch
from
f3c2060 to
e0890af
Compare
enjojoy
force-pushed
the
feat/display-multitoken-tx
branch
2 times, most recently
from
f657e02 to
10af636
Compare
jvaclavik
reviewed
Nov 22, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
tomasklim
requested changes
Nov 23, 2024
This comment was marked as resolved.
This comment was marked as resolved.
enjojoy
force-pushed
the
feat/display-multitoken-tx
branch
2 times, most recently
from
307a4d3 to
76bbde3
Compare
|
It would be nice to remake GraphTooltipAccount component, it's full of custom styles, I was playing around with it but decided to leave it for later to not make this PR too big |
enjojoy
force-pushed
the
feat/display-multitoken-tx
branch
from
76bbde3 to
ee62fed
Compare
adamhavel
reviewed
Nov 26, 2024
packages/suite/src/components/wallet/TransactionItem/TransactionItem.tsx
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
enjojoy
force-pushed
the
feat/display-multitoken-tx
branch
4 times, most recently
from
90133fd to
ee47ee0
Compare
enjojoy
force-pushed
the
feat/display-multitoken-tx
branch
from
f0b55df to
5ba7848
Compare
adamhavel
reviewed
Nov 29, 2024
...e/modals/ReduxModal/UserContextModal/TxDetailModal/AdvancedTxDetails/IODetails/IODetails.tsx
Outdated
Show resolved
Hide resolved
tomasklim
requested changes
Nov 29, 2024
enjojoy
force-pushed
the
feat/display-multitoken-tx
branch
from
8e62a0b to
3da6c65
Compare
tomasklim
reviewed
Dec 1, 2024
packages/suite/src/components/wallet/TransactionItem/TransactionTarget/TransactionTarget.tsx
Show resolved
Hide resolved
enjojoy
force-pushed
the
feat/display-multitoken-tx
branch
5 times, most recently
from
a0d9855 to
5042a57
Compare
adamhavel
approved these changes
Dec 2, 2024
enjojoy
force-pushed
the
feat/display-multitoken-tx
branch
2 times, most recently
from
ec75601 to
70a5f9d
Compare
enjojoy
force-pushed
the
feat/display-multitoken-tx
branch
2 times, most recently
from
bc45a18 to
497c043
Compare
enjojoy
force-pushed
the
feat/display-multitoken-tx
branch
from
497c043 to
92860f0
Compare
enjojoy
force-pushed
the
feat/display-multitoken-tx
branch
from
92860f0 to
ae569e6
Compare
tomasklim
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed display of multitoken values for ERC-1155
Related Issue
Resolve #8036
Screenshots:
Before:
After:
Before:
After:
Before:
After:
Before:
After: