feat(suite-native): send form normal fee level validation #14348
Conversation
| precomposedFeeLevels, | ||
| } = context; | ||
|
|
||
| // transaction amount + normal fee has to be lower than account balance |
There was a problem hiding this comment.
How is this comment relevant to the following line? 🤔 It's not obvious at all.
There was a problem hiding this comment.
better comment added in 5189ad1
| const DEFAULT_VALUES = [ | ||
| { | ||
| amount: '', | ||
| address: '', | ||
| fiat: '', | ||
| }, | ||
| ] as const satisfies SendOutputsFormValues['outputs']; |
| useEffect(() => { | ||
| if (watchedFormValues && isValid) debounce(storeFormDraftIfValid); | ||
| }, [isValid, storeFormDraftIfValid, watchedFormValues, debounce]); | ||
| if (!account) return; |
There was a problem hiding this comment.
Would it make sense to move this at the very beginning of the callback block and change like this?
| if (!account) return; | |
| if (!account || !networkFeeInfo) return; |
PeKne
force-pushed
the
fix/native/normal-fee-send-form-validation
branch
from
5189ad1
to
0adad27
Compare
|
@yanascz In the end, the solution utilizes the calculation of send max with the normal fee level, as you suggested. So the normal fee send max amount is calculated right away when the user enters the send form screen and recalculated if the address is changed. Like this, we have a numeric value to compare with the amount, and we don't have to recalculate fees on every change. The solution of calculating send max was inspired by desktop implementation. Hit me up in Slack if you need to clarify anything. The original Commits were squashed and force-pushed because the new solution conflicted with the original one. Please do the full review again 🙏. |
PeKne
force-pushed
the
fix/native/normal-fee-send-form-validation
branch
from
0adad27
to
b96ce1d
Compare
Description
(X + normal fee) > available balanceform shows error and user can not continue until he lowers the amountRelated Issue
Resolve #13782
Screenshots: