Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coinmarket): switch off coinjoin #14338

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix(coinmarket): switch off coinjoin #14338

wants to merge 4 commits into from
+48 −9

Conversation

adderpositive
Copy link
Contributor

Description

Disable coinjoin account in the trade section when trying to buy/exchange BTC. Also if a coinjoin account is already active, it will not be visible in the select list of discovered accounts.

Related Issue

Resolve #14303

@adderpositive adderpositive added bug Something isn't working as expected +Invity Related to Invity project labels Sep 13, 2024
@adderpositive adderpositive self-assigned this Sep 13, 2024
@Hermez-cz Hermez-cz self-requested a review September 17, 2024 05:39
Hermez-cz
Hermez-cz approved these changes Sep 17, 2024
View reviewed changes
Copy link

@Hermez-cz Hermez-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I can't see how it looks like, but it makes sense and all the code changes look like it will simply be gone 👍

@Lemonexe Lemonexe self-requested a review September 17, 2024 06:04
Lemonexe
Lemonexe approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@Lemonexe Lemonexe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM, does what it's supposed to, just one comment 🚀

Btw you can still sell & swap from existing coinjoin accounts. I assume we don't want to remove that? Just checking.
EDIT: removed.

.../src/components/suite/modals/ReduxModal/UserContextModal/AddAccountModal/AddAccountModal.tsx Outdated Show resolved Hide resolved
@Lemonexe Lemonexe self-requested a review September 17, 2024 09:15
Lemonexe
Lemonexe approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@Lemonexe Lemonexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the modal bugfix here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lemonexe Lemonexe Lemonexe approved these changes

@Hermez-cz Hermez-cz Hermez-cz approved these changes

@LukasRada LukasRada Awaiting requested review from LukasRada

Assignees

@adderpositive adderpositive

Labels
bug Something isn't working as expected +Invity Related to Invity project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coinmarket - Disable coinjoin account in trade section
3 participants
@adderpositive @Lemonexe @Hermez-cz