Feat/blockbook network #13670
Draft
Feat/blockbook network #13670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasklim
requested review from
MiroslavProchazka,
a team,
mroz22,
szymonlesisz,
martykan,
jvaclavik,
peter-sanderson and
marekrjpolak
as code owners
tomasklim
force-pushed
the
feat/blockbook-network
branch
from
ce0d388 to
256472d
Compare
jvaclavik
approved these changes
Aug 7, 2024
tomasklim
force-pushed
the
feat/blockbook-network
branch
from
256472d to
0a588ea
Compare
mroz22
reviewed
Aug 7, 2024
| n => n.name.toLowerCase() === name || n.shortcut.toLowerCase() === name, | ||
| ); | ||
| // name is network symbol (bnb, op, btc) | ||
| return networks.find(n => n.name.toLowerCase() === name || n.chain?.toLowerCase() === name); |
tomasklim
force-pushed
the
feat/blockbook-network
branch
2 times, most recently
from
bfb7033 to
2becada
Compare
tomasklim
force-pushed
the
feat/blockbook-network
branch
from
2becada to
9d702ff
Compare
adderpositive
force-pushed
the
feat/blockbook-network
branch
from
9d702ff to
61c9531
Compare
tomasklim
commented
Dec 11, 2024
| @@ -18,6 +18,7 @@ export default { | |||
| data: { | |||
There was a problem hiding this comment.
please add fixture for network which has different shortcut than network
tomasklim
force-pushed
the
feat/blockbook-network
branch
2 times, most recently
from
985c2d3 to
4a3455f
Compare
tomasklim
force-pushed
the
feat/blockbook-network
branch
from
4a3455f to
f5a2015
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve #14724