ci(github): unify style in connect e2e test workflow

.github/actions/release-connect/action.yml

@@ -95,7 +95,7 @@ runs:
       run: |
         yarn workspace @trezor/connect-explorer build
 
-    # this step should upload build result to s3 bucket DEV_SERVER_HOSTNAME using awscli
+    # this step should upload build result to s3 bucket "serverHostname" using awscli
     - name: Upload connect to ${{ inputs.serverHostname }}
       shell: bash
       env:
@@ -132,7 +132,7 @@ runs:
       if: inputs.uploadArtifacts == 'true'
       uses: actions/upload-artifact@v4
       with:
-        name: connect-example-webextension-${{ inputs.serverHostname }}-${{ github.run_attempt }}-${{ github.run_id }}
+        name: connect-example-webextension-${{ inputs.serverHostname }}
         path: |
           packages/connect-examples/webextension-mv2/build
           packages/connect-examples/webextension-mv3/build
@@ -142,6 +142,6 @@ runs:
       if: inputs.uploadArtifacts == 'true'
       uses: actions/upload-artifact@v4
       with:
-        name: connect-explorer-webextension-${{ inputs.serverHostname }}-${{ github.run_attempt }}-${{ github.run_id }}
+        name: connect-explorer-webextension-${{ inputs.serverHostname }}
         path: |
           packages/connect-explorer/build-webextension

.github/workflows/template-connect-popup-test-params.yml

@@ -3,30 +3,30 @@ name: "[Template] connect-popup test params"
 on:
   workflow_call:
     inputs:
-      test-name:
+      testName:
         description: "Test name to be run (e.g. `analytics` or `popup-close`)"
         type: "string"
         required: true
-      DEV_SERVER_HOSTNAME:
+      serverHostname:
         description: "URL used by popup connect tests (e.g. dev.suite.sldev.cz)"
         type: "string"
         required: true
-      run-webextension:
+      runWebextension:
         description: "Flag to indicate whether to run the webextension job"
         type: "boolean"
         required: false
         default: false
-      run-web:
+      runWeb:
         description: "Flag to indicate whether to run the web job"
         type: "boolean"
         required: false
         default: true
-      run-core-in-popup:
+      runCoreInPopup:
         description: "Flag to indicate whether to run the core-in-popup job"
         type: "boolean"
         required: false
         default: false
-      build-overview:
+      buildOverview:
         description: "Flag to indicate whether to build connect-popup-overview.html"
         type: "boolean"
         required: false
@@ -36,7 +36,7 @@ jobs:
   web:
     name: web
     runs-on: ubuntu-latest
-    if: ${{ inputs.run-web }}
+    if: ${{ inputs.runWeb }}
     steps:
       - uses: actions/checkout@v4
         with:
@@ -53,16 +53,16 @@ jobs:
 
       - name: Run connect popup test
         env:
-          URL: https://${{ inputs.DEV_SERVER_HOSTNAME }}/connect/${{ steps.extract_branch.outputs.branch }}/
+          URL: https://${{ inputs.serverHostname }}/connect/${{ steps.extract_branch.outputs.branch }}/
           # skip settings page, this url is set at build time anyway
-          #TREZOR_CONNECT_SRC: https://${{ inputs.DEV_SERVER_HOSTNAME }}/connect/${{ steps.extract_branch.outputs.branch }}/
+          #TREZOR_CONNECT_SRC: https://${{ inputs.serverHostname }}/connect/${{ steps.extract_branch.outputs.branch }}/
           CI_COMMIT_BRANCH: ${{ steps.extract_branch.outputs.branch }}
-          CI_JOB_NAME: ${{ inputs.test-name }}-${{ github.run_attempt }}
+          CI_JOB_NAME: ${{ inputs.testName }}-${{ github.run_attempt }}
         run: |
-          ./docker/docker-connect-popup-ci.sh ${{ inputs.test-name }}
+          ./docker/docker-connect-popup-ci.sh ${{ inputs.testName }}
 
       - name: Prepare static overview
-        if: ${{ inputs.build-overview }}
+        if: ${{ inputs.buildOverview }}
         run: |
           echo "Preparing static overview"
           mkdir -p tmp_overview_directory
@@ -71,17 +71,17 @@ jobs:
 
       - name: Upload static overview artifact
         uses: actions/upload-artifact@v4
-        if: ${{ inputs.build-overview }}
+        if: ${{ inputs.buildOverview }}
         with:
-          name: core-in-popup-static-overview-${{ inputs.test-name }}-${{ github.run_attempt }}
+          name: core-in-popup-static-overview-${{ inputs.testName }}-${{ github.run_attempt }}
           path: |
             tmp_overview_directory/
 
       - name: Upload artifacts
         if: failure()
         uses: actions/upload-artifact@v4
         with:
-          name: web-test-artifacts-${{ inputs.test-name }}-${{ github.run_attempt }}-${{ github.run_id }}
+          name: web-test-artifacts-${{ inputs.testName }}-${{ github.run_attempt }}-${{ github.run_id }}
           path: |
             packages/connect-popup/test-results
 
@@ -96,7 +96,7 @@ jobs:
   webextension:
     name: webextension
     runs-on: ubuntu-latest
-    if: ${{ inputs.run-webextension }}
+    if: ${{ inputs.runWebextension }}
     steps:
       - uses: actions/checkout@v4
         with:
@@ -114,33 +114,33 @@ jobs:
       - name: Download artifact from build
         uses: actions/download-artifact@v4
         with:
-          name: connect-explorer-webextension
+          name: connect-explorer-webextension-${{ inputs.serverHostname }}
           path: |
             packages/connect-explorer/build-webextension
 
       - name: Build example webextension
-        if: ${{ inputs.test-name == 'webextension-example.test' }}
+        if: ${{ inputs.testName == 'webextension-example.test' }}
         env:
-          URL: https://${{ inputs.DEV_SERVER_HOSTNAME }}/connect/${{ steps.extract_branch.outputs.branch }}/
+          URL: https://${{ inputs.serverHostname }}/connect/${{ steps.extract_branch.outputs.branch }}/
         run: |
           yarn workspace @trezor/connect-web build:webextension
           yarn workspace @trezor/connect-web build:inline
           node packages/connect-examples/update-webextensions.js --trezor-connect-src "${URL}" --npm-src "${URL}trezor-connect.js"
 
       - name: Run connect popup test
         env:
-          URL: https://${{ inputs.DEV_SERVER_HOSTNAME }}/connect/${{ steps.extract_branch.outputs.branch }}/
-          #TREZOR_CONNECT_SRC: https://${{ inputs.DEV_SERVER_HOSTNAME }}/connect/${{ steps.extract_branch.outputs.branch }}/
+          URL: https://${{ inputs.serverHostname }}/connect/${{ steps.extract_branch.outputs.branch }}/
+          #TREZOR_CONNECT_SRC: https://${{ inputs.serverHostname }}/connect/${{ steps.extract_branch.outputs.branch }}/
           IS_WEBEXTENSION: true
         run: |
-          ./docker/docker-connect-popup-ci.sh ${{ inputs.test-name }}
+          ./docker/docker-connect-popup-ci.sh ${{ inputs.testName }}
 
       - name: Upload artifacts
         # We upload test artifacts only if it fails and we use it to `Check Test Success` in next step.
         if: failure()
         uses: actions/upload-artifact@v4
         with:
-          name: webextension-test-artifacts-${{ inputs.test-name }}-${{ github.run_attempt }}-${{ github.run_id }}
+          name: webextension-test-artifacts-${{ inputs.testName }}-${{ github.run_attempt }}-${{ github.run_id }}
           path: |
             packages/connect-popup/test-results
 
@@ -155,7 +155,7 @@ jobs:
   core_in_popup:
     name: core_in_popup
     runs-on: ubuntu-latest
-    if: ${{ inputs.run-core-in-popup }}
+    if: ${{ inputs.runCoreInPopup }}
     steps:
       - uses: actions/checkout@v4
         with:
@@ -172,17 +172,17 @@ jobs:
 
       - name: Run connect popup test
         env:
-          URL: https://${{ inputs.DEV_SERVER_HOSTNAME }}/connect/${{ steps.extract_branch.outputs.branch }}/?core-in-popup=true
+          URL: https://${{ inputs.serverHostname }}/connect/${{ steps.extract_branch.outputs.branch }}/?core-in-popup=true
           CORE_IN_POPUP: true
           # skip settings page, this url is set at build time anyway
-          #TREZOR_CONNECT_SRC: https://${{ inputs.DEV_SERVER_HOSTNAME }}/connect/${{ steps.extract_branch.outputs.branch }}/
+          #TREZOR_CONNECT_SRC: https://${{ inputs.serverHostname }}/connect/${{ steps.extract_branch.outputs.branch }}/
           CI_COMMIT_BRANCH: ${{ steps.extract_branch.outputs.branch }}
-          CI_JOB_NAME: ${{ inputs.test-name }}-${{ github.run_attempt }}
+          CI_JOB_NAME: ${{ inputs.testName }}-${{ github.run_attempt }}
         run: |
-          ./docker/docker-connect-popup-ci.sh ${{ inputs.test-name }}
+          ./docker/docker-connect-popup-ci.sh ${{ inputs.testName }}
 
       - name: Prepare static overview
-        if: ${{ inputs.build-overview }}
+        if: ${{ inputs.buildOverview }}
         run: |
           echo "Preparing static overview"
           mkdir -p tmp_overview_directory
@@ -191,17 +191,17 @@ jobs:
 
       - name: Upload static overview artifact
         uses: actions/upload-artifact@v4
-        if: ${{ inputs.build-overview }}
+        if: ${{ inputs.buildOverview }}
         with:
-          name: static-overview-${{ inputs.test-name }}-${{ github.run_attempt }}
+          name: static-overview-${{ inputs.testName }}-${{ github.run_attempt }}
           path: |
             tmp_overview_directory/
 
       - name: Upload artifacts
         if: failure()
         uses: actions/upload-artifact@v4
         with:
-          name: core-in-popup-test-artifacts-${{ inputs.test-name }}-${{ github.run_attempt }}-${{ github.run_id }}
+          name: core-in-popup-test-artifacts-${{ inputs.testName }}-${{ github.run_attempt }}-${{ github.run_id }}
           path: |
             packages/connect-popup/test-results
 

.github/workflows/test-connect-popup.yml

@@ -69,71 +69,71 @@ jobs:
     needs: [build-deploy]
     uses: ./.github/workflows/template-connect-popup-test-params.yml
     with:
-      test-name: methods.test
-      DEV_SERVER_HOSTNAME: dev.suite.sldev.cz
-      run-webextension: ${{ github.event_name == 'schedule' }}
-      run-core-in-popup: true
-      build-overview: true
+      testName: methods.test
+      serverHostname: dev.suite.sldev.cz
+      runWebextension: ${{ github.event_name == 'schedule' }}
+      runCoreInPopup: true
+      buildOverview: true
 
   popup-close:
     needs: [build-deploy]
     uses: ./.github/workflows/template-connect-popup-test-params.yml
     with:
-      test-name: popup-close.test
-      DEV_SERVER_HOSTNAME: dev.suite.sldev.cz
-      run-webextension: true
-      run-core-in-popup: true
+      testName: popup-close.test
+      serverHostname: dev.suite.sldev.cz
+      runWebextension: true
+      runCoreInPopup: true
 
   passphrase:
     needs: [build-deploy]
     uses: ./.github/workflows/template-connect-popup-test-params.yml
     with:
-      test-name: passphrase.test
-      DEV_SERVER_HOSTNAME: dev.suite.sldev.cz
-      run-webextension: true
-      run-core-in-popup: true
+      testName: passphrase.test
+      serverHostname: dev.suite.sldev.cz
+      runWebextension: true
+      runCoreInPopup: true
 
   popup-pages:
     needs: [build-deploy]
     uses: ./.github/workflows/template-connect-popup-test-params.yml
     with:
-      test-name: popup-pages.test
-      DEV_SERVER_HOSTNAME: dev.suite.sldev.cz
+      testName: popup-pages.test
+      serverHostname: dev.suite.sldev.cz
 
   browser-support:
     needs: [build-deploy]
     uses: ./.github/workflows/template-connect-popup-test-params.yml
     with:
-      test-name: browser-support.test
-      DEV_SERVER_HOSTNAME: dev.suite.sldev.cz
+      testName: browser-support.test
+      serverHostname: dev.suite.sldev.cz
 
   permissions:
     needs: [build-deploy]
     uses: ./.github/workflows/template-connect-popup-test-params.yml
     with:
-      test-name: permissions.test
-      DEV_SERVER_HOSTNAME: dev.suite.sldev.cz
+      testName: permissions.test
+      serverHostname: dev.suite.sldev.cz
 
   transport:
     needs: [build-deploy]
     uses: ./.github/workflows/template-connect-popup-test-params.yml
     with:
-      test-name: transport.test
-      DEV_SERVER_HOSTNAME: dev.suite.sldev.cz
+      testName: transport.test
+      serverHostname: dev.suite.sldev.cz
 
   unchained:
     needs: [build-deploy]
     uses: ./.github/workflows/template-connect-popup-test-params.yml
     with:
-      test-name: unchained.test
-      DEV_SERVER_HOSTNAME: dev.suite.sldev.cz
-      run-web: ${{ github.event_name == 'schedule' }}
+      testName: unchained.test
+      serverHostname: dev.suite.sldev.cz
+      runWeb: ${{ github.event_name == 'schedule' }}
 
   webextension-examples:
     needs: [build-deploy]
     uses: ./.github/workflows/template-connect-popup-test-params.yml
     with:
-      test-name: webextension-example.test
-      DEV_SERVER_HOSTNAME: dev.suite.sldev.cz
-      run-webextension: true
-      run-web: false
+      testName: webextension-example.test
+      serverHostname: dev.suite.sldev.cz
+      runWebextension: true
+      runWeb: false