fix(suite-native): improve DAC error handling and report check result

trezor · Dec 2, 2024 · 0b93197 · 0b93197
1 parent ce41c4d
commit 0b93197
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 7 deletions.
diff --git a/suite-native/analytics/src/constants.ts b/suite-native/analytics/src/constants.ts
@@ -49,4 +49,5 @@ export enum EventType {
     SendTransactionDispatched = 'send/transaction_dispatched',
     SendFlowExited = 'send/flow_exited',
     DeviceSettingsPinProtectionChange = 'device_settings/pin_protection_change',
+    DeviceSettingsAuthenticityCheck = 'device_settings/authenticity_check',
 }
diff --git a/suite-native/analytics/src/events.ts b/suite-native/analytics/src/events.ts
@@ -5,7 +5,7 @@ import { FeeLevelLabel, TokenAddress, TokenSymbol } from '@suite-common/wallet-t
 import { DeviceModelInternal, VersionArray } from '@trezor/connect';
 
 import { EventType } from './constants';
-import { AnalyticsSendFlowStep } from './types';
+import { AnalyticsSendFlowStep, DeviceAuthenticityCheckResult } from './types';
 
 export type SuiteNativeAnalyticsEvent =
     | {
@@ -310,4 +310,10 @@ export type SuiteNativeAnalyticsEvent =
           payload: {
               action: 'enable' | 'change' | 'disable';
           };
+      }
+    | {
+          type: EventType.DeviceSettingsAuthenticityCheck;
+          payload: {
+              result: DeviceAuthenticityCheckResult;
+          };
       };
diff --git a/suite-native/analytics/src/types.ts b/suite-native/analytics/src/types.ts
@@ -4,3 +4,5 @@ export type AnalyticsSendFlowStep =
     | 'address_review'
     | 'outputs_review'
     | 'destination_tag_review';
+
+export type DeviceAuthenticityCheckResult = 'successful' | 'compromised' | 'cancelled' | 'failed';
diff --git a/suite-native/module-device-settings/src/components/DeviceAuthenticityCard.tsx b/suite-native/module-device-settings/src/components/DeviceAuthenticityCard.tsx
@@ -3,6 +3,7 @@ import { useSelector } from 'react-redux';
 
 import { useNavigation } from '@react-navigation/native';
 
+import { analytics, DeviceAuthenticityCheckResult, EventType } from '@suite-native/analytics';
 import { selectDevice } from '@suite-common/wallet-core';
 import { requestPrioritizedDeviceAccess } from '@suite-native/device-mutex';
 import { useAlert } from '@suite-native/alerts';
@@ -31,6 +32,15 @@ export const DeviceAuthenticityCard = () => {
 
     const device = useSelector(selectDevice);
 
+    const reportCheckResult = useCallback(
+        (result: DeviceAuthenticityCheckResult) =>
+            analytics.report({
+                type: EventType.DeviceSettingsAuthenticityCheck,
+                payload: { result },
+            }),
+        [],
+    );
+
     const checkAuthenticity = useCallback(async () => {
         navigation.navigate(DeviceStackRoutes.DeviceAuthenticity);
 
@@ -48,13 +58,25 @@ export const DeviceAuthenticityCard = () => {
 
         const { success, payload } = result.payload;
         if (success) {
-            navigation.navigate(DeviceAuthenticityStackRoutes.AuthenticitySummary, {
-                checkResult: payload.valid ? 'successful' : 'compromised',
-            });
-        } else if (payload.code === 'Failure_ActionCancelled') {
-            navigation.goBack();
+            const checkResult = payload.valid ? 'successful' : 'compromised';
+            navigation.navigate(DeviceAuthenticityStackRoutes.AuthenticitySummary, { checkResult });
+            reportCheckResult(checkResult);
+        } else {
+            const errorCode = payload.code;
+            if (errorCode === 'Failure_ActionCancelled' || errorCode === 'Failure_PinCancelled') {
+                navigation.goBack();
+                reportCheckResult('cancelled');
+            } else if (errorCode === 'Method_Interrupted') {
+                // navigation.goBack() already called via the X button
+                reportCheckResult('cancelled');
+            } else {
+                navigation.navigate(DeviceAuthenticityStackRoutes.AuthenticitySummary, {
+                    checkResult: 'compromised',
+                });
+                reportCheckResult('failed');
+            }
         }
-    }, [navigation, device]);
+    }, [device, navigation, reportCheckResult]);
 
     const showInfoAlert = useCallback(() => {
         showAlert({