Fix notebook filter for distance-based graph #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goliath-walker
changed the title
goliath-walker
commented
Oct 1, 2022
goliath-walker
commented
Oct 1, 2022
Comment on lines
+144
to
+151
| // Get a list of valid notebook names to filter out. | ||
| // TODO: Is this even needed? | ||
| //filter = { | ||
| // ...filter, | ||
| // filteredNotebookNames: filter.filteredNotebookNames.filter((name) => | ||
| // cache.notebookIdsByName.has(name) | ||
| // ), | ||
| //}; |
There was a problem hiding this comment.
Please evaluate if needed
There was a problem hiding this comment.
I vaguely remember running into some sort of exception with invalid notebook names. I wasn't able to reproduce it locally with your PR. Maybe it's safe to delete?
|
Hey sorry, I'll take a look today! |
treymo
approved these changes
Oct 30, 2022
Comment on lines
+144
to
+151
| // Get a list of valid notebook names to filter out. | ||
| // TODO: Is this even needed? | ||
| //filter = { | ||
| // ...filter, | ||
| // filteredNotebookNames: filter.filteredNotebookNames.filter((name) => | ||
| // cache.notebookIdsByName.has(name) | ||
| // ), | ||
| //}; |
There was a problem hiding this comment.
I vaguely remember running into some sort of exception with invalid notebook names. I wasn't able to reproduce it locally with your PR. Maybe it's safe to delete?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix distance-based graph to consider excluded notebooks. Currently excluded notebooks only work, if all notes are shown in graph.
I needed to split up the
filterNotesByNotebookNameintoNotebookFilterandNotebookCache, so it can be reused for single note filtering.This way
shouldIncludeNotebook(previouslyshouldIncludeNote) is no closure and becomes a function of its own.