Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve communication between plugin and ui & bundle ui #36

Merged
merged 5 commits into from
Oct 2, 2021
Merged

refactor: Improve communication between plugin and ui & bundle ui #36

merged 5 commits into from
Oct 2, 2021

Commits on Sep 23, 2021

  1. refactor: Improve communication between plugin and ui & bundle ui dep…

    …endencies
    
    The plugin is relying on a timer that triggers a full refresh every second.
    This impacts UI responsiveness and increase resource usage.
    The UI script also uses a timer to figure out when the d3 library has finished loading.
    
    This commit addresses both issues by:
    
    * Replacing the first timer by a poll mechanism. When the API notifies
      on a change, a model change is added to a queue. The ui checks the queue
      for new updates and apply them. This allows for a cleaner execution model
      and improves responsiveness.
    
    * Using extra-scripts to bundle ui & d3 with webpack. This removes the
      second timer and have the side benefit of reducing the plugin's size by
      5 due to treeshaking.
    agerardin committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    a15d8ab View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Configuration menu
    Copy the full SHA
    743619f View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2021

  1. Configuration menu
    Copy the full SHA
    ba2b807 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2021

  1. review PR changes

    agerardin committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    da03d53 View commit details
    Browse the repository at this point in the history
  2. removed unused redraw()

    agerardin committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    7a73822 View commit details
    Browse the repository at this point in the history