Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage overview #302

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Homepage overview #302

merged 2 commits into from
Apr 6, 2022

Conversation

nelsonkopliku
Copy link
Member

Exposes /api/sap_systems/health

[
  {
    "clusters_health": "unknown",
    "database_health": "passing",
    "hosts_health": "unknown",
    "id": "f534a4ad-cef7-5234-b196-e67082ffb50c",
    "sapsystem_health": "passing",
    "sid": "NWD"
  },
  {
    "clusters_health": "unknown",
    "database_health": "passing",
    "hosts_health": "unknown",
    "id": "6c9208eb-a5bb-57ef-be5c-6422dedab602",
    "sapsystem_health": "passing",
    "sid": "NWP"
  },
  {
    "clusters_health": "unknown",
    "database_health": "passing",
    "hosts_health": "unknown",
    "id": "cd52e571-c897-5bba-b0f9-e155ceca1fff",
    "sapsystem_health": "passing",
    "sid": "NWQ"
  }
]

@nelsonkopliku nelsonkopliku marked this pull request as ready for review April 6, 2022 13:20
@nelsonkopliku nelsonkopliku force-pushed the homepage_overview branch 2 times, most recently from 46e5f17 to 6f60852 Compare April 6, 2022 13:33
dottorblaster
dottorblaster approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little comment but I like it

fabriziosestito
fabriziosestito approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@fabriziosestito fabriziosestito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just couple of naming suggestions and nitpicks

@nelsonkopliku nelsonkopliku force-pushed the homepage_overview branch 2 times, most recently from d5eb784 to da67dbe Compare April 6, 2022 14:34
@nelsonkopliku nelsonkopliku merged commit 301f1a6 into main Apr 6, 2022
@nelsonkopliku nelsonkopliku deleted the homepage_overview branch April 6, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottorblaster dottorblaster dottorblaster approved these changes

@fabriziosestito fabriziosestito fabriziosestito approved these changes

@rtorrero rtorrero Awaiting requested review from rtorrero

@arbulu89 arbulu89 Awaiting requested review from arbulu89

@stefanotorresi stefanotorresi Awaiting requested review from stefanotorresi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nelsonkopliku @dottorblaster @fabriziosestito