Merge pull request #613 from Crozzers/fix-smarty-pants-runtime-check

Fix smarty pants extra not triggering when it should (#611)
trentm · Dec 7, 2024 · ed820a6 · ed820a6
2 parents 1032d35 + 7677802
commit ed820a6
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -6,6 +6,7 @@
 - [pull #607] Fix `middle-word-em` extra preventing strongs from being recognized (#606)
 - [pull #609] Add option to output to file in CLI (#608)
 - [pull #612] Fix footnote labels appearing out-of-order (#536)
+- [pull #613] Fix smarty pants extra not triggering when it should (#611)
 
 
 ## python-markdown2 2.5.1

diff --git a/lib/markdown2.py b/lib/markdown2.py
@@ -3321,7 +3321,13 @@ def run(self, text):
         return text
 
     def test(self, text):
-        return "'" in text or '"' in text
+        return any(i in text for i in (
+            "'",
+            '"',
+            '--',
+            '...',
+            '. . .'
+        ))
 
 
 class Strike(Extra):

diff --git a/test/tm-cases/smarty_pants_issue611.html b/test/tm-cases/smarty_pants_issue611.html
@@ -0,0 +1,3 @@
+<p>ho ho &#8212; ho ho</p>
+
+<p>ho &#8220;ho&#8221; &#8212; ho ho</p>
diff --git a/test/tm-cases/smarty_pants_issue611.opts b/test/tm-cases/smarty_pants_issue611.opts
@@ -0,0 +1 @@
+{"extras": ["smarty-pants"]}
diff --git a/test/tm-cases/smarty_pants_issue611.text b/test/tm-cases/smarty_pants_issue611.text
@@ -0,0 +1,3 @@
+ho ho --- ho ho
+
+ho "ho" --- ho ho
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		<p>ho ho — ho ho</p>

		<p>ho “ho” — ho ho</p>