Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken links described in issue#2701 #2702

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devskillz47
Copy link
Contributor

Pull request

Fix "broken" links included in the Issue#2701(#2701)

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (66e238d) to head (eed6e2f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2702      +/-   ##
==========================================
+ Coverage   91.33%   91.35%   +0.01%     
==========================================
  Files         309      309              
  Lines       60380    60380              
==========================================
+ Hits        55151    55160       +9     
+ Misses       5229     5220       -9     
Flag Coverage Δ
e2e-command 11.25% <ø> (ø)
e2e-integration 50.43% <ø> (+0.18%) ⬆️
e2e-unit 12.54% <ø> (ø)
e2etests 52.76% <ø> (+0.18%) ⬆️
tremorapi 14.47% <ø> (-0.28%) ⬇️
tremorcodec 63.96% <ø> (ø)
tremorcommon 63.04% <ø> (ø)
tremorconnectors 28.75% <ø> (ø)
tremorconnectorsaws 11.22% <ø> (ø)
tremorconnectorsazure 4.67% <ø> (ø)
tremorconnectorsgcp 25.31% <ø> (ø)
tremorconnectorsobjectstorage 0.06% <ø> (ø)
tremorconnectorsotel 12.52% <ø> (ø)
tremorconnectorstesthelpers 68.25% <ø> (ø)
tremorinflux 87.71% <ø> (ø)
tremorinterceptor 55.34% <ø> (ø)
tremorpipeline 31.06% <ø> (ø)
tremorruntime 47.12% <ø> (+<0.01%) ⬆️
tremorscript 54.90% <ø> (ø)
tremorsystem 5.76% <ø> (ø)
tremorvalue 69.52% <ø> (ø)
unittests 89.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66e238d...eed6e2f. Read the comment docs.

@devskillz47 devskillz47 reopened this Dec 21, 2024
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we link this to edge instead of 0.12:

  1. edge will not go out of date as a long
  2. edge effects what is directly in github so it is the more correct link I think

@devskillz47
Copy link
Contributor Author

will do, but took a little break for the holidays... :p

@Licenser
Copy link
Member

Licenser commented Jan 7, 2025

All good, I just wanted to track it before I forget :)

@devskillz47
Copy link
Contributor Author

devskillz47 commented Jan 7, 2025 via email

@devskillz47
Copy link
Contributor Author

Np. :p

@devskillz47
Copy link
Contributor Author

so, i had a more in depth look at this. it seems that currently everything points to v0.12. my only concern in moving it to edge would be that if in the installation instructions we point to the latest release (in this case v0.12) and in the documentation we point it to edge the features described in the documentation might not be there for the users who followed the instructions which could be quite cumbersome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants