Python HL SDK: use IfNoneMatch to support conditional write (aka exclusive creation) #9309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
force-pushed
the
fix/exclusive-file-create-mode
branch
from
cf6c55f to
32a69f9
Compare
…usive creation) Closes treeverse#7505. This replaces existing obj.exists() check with conditional writes with 'IfNoneMatch: *'. I have tried to maintain compat in terms of error raised, by raising `ObjectExistsError` on pre-condition failure.
skshetry
force-pushed
the
fix/exclusive-file-create-mode
branch
from
32a69f9 to
e69ea94
Compare
nopcoder
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
Looks good, had a small comment related to a check in the code.
Also, if you can open a follow-up issues:
- Refactor: the exception handling should use
api_exception_handlerwith customer handler to address the specific if_none_match. This should align all the exceptions thrown based on the API to the SDK exception - Bug: it seems we have a resource leak while exception is thrown calling
closeand the upload/link throws an exception we continue to raise without closing the fd.
skshetry
commented
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Closes #7505.
This replaces existing
obj.exists()check with conditional writes using 'IfNoneMatch: *'. I have tried to maintain compat in terms of error raised, by raisingObjectExistsErroron pre-condition failure.Testing Details
How were the changes tested?
There is an existing
test_object_upload_existsthat covers this. I have extended this test by parametrizing it withpre_sign=True|False.Breaking Change?
Does this change break any existing functionality? (API, CLI, Clients)
No.
Additional info
Logs, outputs, screenshots of changes if applicable (CLI / GUI changes)
Contact Details
How can we get in touch with you if we need more info? (ex. [email protected])