Specified that Maven must run with Java 8 in docs #8706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annaseli
added
docs
|
🎊 PR Preview 21016a3 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-8706.surge.sh 🕐 Build time: 0.01s
🤖 By surge-preview |
E2E Test Results - Quickstart |
E2E Test Results - DynamoDB Local - Local Block Adapter |
nopcoder
requested changes
Feb 24, 2025
clients/hadoopfs/README.md
Outdated
Comment on lines
10
to
16
| ## Building | ||
|
|
||
| Maven must be run with Java 8. | ||
|
|
||
| ## Testing | ||
|
|
||
| Maven tests must be run with Java 8. |
There was a problem hiding this comment.
Suggest to merge the two and write that the project using Maven, with a prerequisite of having Java 8 installed.
| 1. Java 8 | ||
| * Apple M1 users can install this from [Azul Zulu Builds for Java JDK](https://www.azul.com/downloads/?package=jdk). Builds for Intel-based Macs are available from [java.com](https://www.java.com/en/download/help/mac_install.html). | ||
| 1. [Maven](https://maven.apache.org/) with Java 8 |
There was a problem hiding this comment.
Java 8 is already required at line 42.
Also Maven was specified - but just limited to the spark client - which we need to update.
There was a problem hiding this comment.
@nopcoder
So, do you mean I should write:
"Maven - required for building and testing Spark client code, as well as the hadoopfs client."
instead of my original version:
"Maven with Java 8
- Java 8 is required for building and testing the hadoopfs client.
"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8581
Change Description
Background
When running make test with Maven using Java version greater than 8, the following error occurs:
Fix And Updating Documentation
The failure happens in the hadoopfs client tests. However, when using Java 8, the tests pass successfully.
I updated the Contributing to lakeFS documentation and the clients/hadoopfs README by adding a building and testing section, specifying that Maven should be used with Java 8.
Testing Details
I tested the appearance of the new document using Jekyll in Docker.