Skip to content

Use bulk calls for checking which entries are not in remote #10923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
falko17 wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −3
Draft

Use bulk calls for checking which entries are not in remote #10923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16e14e5
Add optional bulk_remote_exists
sjawhar Dec 3, 2025
f62458c
fix: correctly update progress bar for bulk remote exist queries
falko17 Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions dvc/repo/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,15 +456,17 @@ def _onerror(entry, exc):
n += 1
cb.set_size(n)

results = storage_map.bulk_remote_exists(
list(entries.values()), refresh=remote_refresh, callback=cb
)
for key, entry in entries.items():
k = (*key, "") if entry.meta and entry.meta.isdir else key
try:
if not storage_map.remote_exists(entry, refresh=remote_refresh):
if not results.get(entry, False):
missing_entries.append(os.path.sep.join(k))
except StorageKeyError:
pass
finally:
cb.relative_update()

data_index.onerror = orig_data_index_onerror
return missing_entries

Expand Down
Loading