Goonj code refactor #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging upstream master to my master
|
@AdityaMisra What is this pull request for? Please add details. Second, you are not allowed to merge a pull request without review. |
|
Thanks for adding the details. I've just finished reviewing Sohit's PR.. Can you two sync up and see who needs to back merge from whom? He's adding functionality and you're refactoring, so best keep things in sync. I can then do the PR. |
|
@varunachar I'll sync up with @keshrisohit |
oneAlpha
reviewed
Jun 8, 2018
goonj/channels/base_channel.py
Outdated
|
|
||
| class BaseChannel(object): | ||
| """ | ||
| Base class for all alerting channels | ||
| """ | ||
|
|
||
| @abc.abstractmethod | ||
| def send(self, sev, message, subject, error_id, error, tag_list): | ||
| def send_message(self, sev, message, subject=None, error_id=None, error=None, tag_list=None): |
There was a problem hiding this comment.
make this private by adding _ so that noone will use it directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have just refactored the code.
I know I'm not suppose to merge a PR without anybody's review. I was waiting for Bibek to review it. I've sent him the PR.
If you get time can you review it.