Allow models.PROTECT in the models #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch exception 'ProtectedError' when try to remove a pk with a relation in the model. Only have to define "on_delete=models.PROTECT" in the model fields.
|
@monsanto-pinheiro Thanks for your PR, however I can't consider it unless it includes test for the change. Please add a test and I would gladly approve this PR. |
|
I only did tests for 'tests_unit'. I didn't for functional. Please, can you do it? |
|
@monsanto-pinheiro Same as in #126 (comment). Sorry for not including your PR back in 2020. I'm again working on this package from time to time thus I would like to ask you if you're interested in adjusting this outdated PR to the current code. It would be great to have you as collaborator. Otherwise I would like to thank you for your contribution and include your idea in one of the next releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch exception 'ProtectedError' when try to remove a pk with a relation in the model.
Only have to define "on_delete=models.PROTECT" in the model fields.