Linux-Only Interface, Marking, and IP Unit Tests #488
Conversation
This commit introduces three unit tests focused on interface binding, packet marking, and IP source address spoofing/selection. Each of these tests builds upon the original `MtrPacketTest` base class. To evaluate these network-dependent features, the tests utilize an emulated network environment. To enable this, a small network emulation library, `netem`, has been developed specifically for this purpose. `Netem` allows for the creation of arbitrary network configurations for testing and can reliably set up and clean up virtual network environments on Linux systems. The only dependencies are `iproute2` and `libc`, which are generally pre-installed on most Linux hosts. The commit adds three tests that are expected to fail: 1. Interface Binding: Evaluates the capability of `mtr-packet` to bind to a specific interface. 2. Packet Marking: Assesses the ability of `mtr-packet` to apply a Linux networking mark (fwmark). 3. Source Address Selection: Tests `mtr-packet`'s ability to spoof or bind to a specified source address.
|
The netem seems to fail LINT checks. Please look into that. You should've said: They "expected to fail" issues are issues that should be in progress of being fixed, but these tests actually detect that the issue is still present. |
|
I will investigate the linting issues. Thank you for bringing them to my attention. You are correct, I intended for them to fail with the |
|
OK. great. |
- Remove unused imports - Search for ip executables in known locations - Fix f-string - Ignore assert warnings
|
I believe I've resolved the linting issues; my local version of flake8 is no longer reporting any errors. However, it seems that the CI pipeline is not triggered when I push changes. |
This commit introduces three unit tests focused on interface binding, packet marking, and IP source address spoofing/selection. Each of these tests builds upon the original
MtrPacketTestbase class. To evaluate these network-dependent features, the tests utilize an emulated network environment. To enable this, a small network emulation library,netem, has been developed specifically for this purpose.netemallows for the creation of arbitrary network configurations for testing and can reliably set up and clean up virtual network environments on Linux systems. The only dependencies areiproute2andlibc, which are generally pre-installed on most Linux hosts.The commit adds three tests that are expected to fail (see #485):
mtr-packetto bind to a specific interface.mtr-packetto apply a Linux networking mark (fwmark).mtr-packet's ability to spoof or bind to a specified source address.