Added support for kml time-map response #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnasbr
force-pushed
the
add-kml-response
branch
from
a9333be
to
7fa587a
Compare
arnasbr
changed the title
arnasbr
requested review from
danielnaumau,
PKJonas,
pawel-wroniszewski and
Donatas-L
| if response_class == TimeMapKmlResponse: | ||
| return parse_kml_as(text) | ||
| else: | ||
| return parse_raw_as(response_class, text) |
There was a problem hiding this comment.
hmmm, not a good one. Can you wrap KML in pydantic?
| @@ -369,7 +371,8 @@ async def time_filter_proto_async( | |||
| properties: Optional[List[PropertyProto]] = None, | |||
| ) -> TimeFilterProtoResponse: | |||
| resp = await send_proto_async( | |||
| f"https://{self._sdk_params.proto_host}/api/v2/{country.value}/time-filter/fast/{transportation.value.name}", # noqa | |||
| f"https://{self._sdk_params.proto_host}/api/v2/{country.value}/time-filter/fast/{transportation.value.name}", | |||
There was a problem hiding this comment.
Try not to push unrelated code in prs.
PKJonas
reviewed
Jan 16, 2024
It needs to be reworked probably, this kml library I used makes usage pretty confusing. Eventually we'll come back to it |
|
This PR is a bit outdated, creating a new one is simpler than trying to rebase. New PR: #136 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
application/vnd.google-earth.kml+xmlresponse intime-map