Adding Mapbox provider #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnasbr
commented
Sep 19, 2024
Comment on lines
+73
to
+74
| elif mode == Mode.PUBLIC_TRANSPORT: | ||
| raise ValueError("Public transport is not supported for Mapbox requests") |
There was a problem hiding this comment.
PT is a bit problematic (not just with mapbox, but in general), skipping it for now
There was a problem hiding this comment.
we don't have an env var allowing the user to specify transport mode for now anyways
|
After this I'll make the providers configurable (so the user can pick which providers they want to compare to TravelTime) |
danielnaumau
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.