Skip to content

Remove obsolete code from GCP storage #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roger2hk merged 1 commit into from
Dec 15, 2025
Merged

Remove obsolete code from GCP storage #831

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions storage/gcp/gcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,6 @@ func (a *Appender) updateEntryBundles(ctx context.Context, fromSeq uint64, entri
return nil
}

numAdded := uint64(0)
bundleIndex, entriesInBundle := fromSeq/layout.EntryBundleWidth, fromSeq%layout.EntryBundleWidth
bundleWriter := &bytes.Buffer{}
if entriesInBundle > 0 {
Expand Down Expand Up @@ -675,8 +674,6 @@ func (a *Appender) updateEntryBundles(ctx context.Context, fromSeq uint64, entri
return fmt.Errorf("bundleWriter.Write: %v", err)
}
entriesInBundle++
fromSeq++
numAdded++
if entriesInBundle == layout.EntryBundleWidth {
// This bundle is full, so we need to write it out...
klog.V(1).Infof("In-memory bundle idx %d is full, attempting write to GCS", bundleIndex)
Expand Down
Loading