Skip to content

Replace context.Background() with t.Context() in GCP tests #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roger2hk merged 1 commit into from
Dec 12, 2025
Merged

Replace context.Background() with t.Context() in GCP tests #829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions storage/gcp/gcp_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func newSpannerDB(t *testing.T) (*spanner.Client, func()) {
}

func TestSpannerSequencerAssignEntries(t *testing.T) {
ctx := context.Background()
ctx := t.Context()
db, close := newSpannerDB(t)
defer close()

Expand Down Expand Up @@ -93,7 +93,7 @@ func TestSpannerSequencerAssignEntries(t *testing.T) {
}

func TestSpannerSequencerPushback(t *testing.T) {
ctx := context.Background()
ctx := t.Context()

for _, test := range []struct {
name string
Expand Down Expand Up @@ -148,7 +148,7 @@ func TestSpannerSequencerPushback(t *testing.T) {
}

func TestSpannerSequencerRoundTrip(t *testing.T) {
ctx := context.Background()
ctx := t.Context()
db, close := newSpannerDB(t)
defer close()

Expand Down Expand Up @@ -200,7 +200,7 @@ func TestSpannerSequencerRoundTrip(t *testing.T) {
}

func TestCheckDataCompatibility(t *testing.T) {
ctx := context.Background()
ctx := t.Context()
db, close := newSpannerDB(t)
defer close()

Expand Down Expand Up @@ -253,7 +253,7 @@ func makeTile(t *testing.T, size uint64) *api.HashTile {
}

func TestTileRoundtrip(t *testing.T) {
ctx := context.Background()
ctx := t.Context()
m := newMemObjStore()
s := &logResourceStore{
objStore: m,
Expand Down Expand Up @@ -317,7 +317,7 @@ func makeBundle(t *testing.T, idx uint64, size int) []byte {
}

func TestBundleRoundtrip(t *testing.T) {
ctx := context.Background()
ctx := t.Context()
m := newMemObjStore()
s := &logResourceStore{
objStore: m,
Expand Down Expand Up @@ -361,7 +361,7 @@ func TestBundleRoundtrip(t *testing.T) {
}

func TestPublishTree(t *testing.T) {
ctx := context.Background()
ctx := t.Context()
for _, test := range []struct {
name string
publishInterval time.Duration
Expand Down
Loading