Use entry path for garbage collection #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phbnf
force-pushed
the
GB-re-entry
branch
3 times, most recently
from
cbd31ec to
d0d22c7
Compare
AlCutter
reviewed
Dec 8, 2025
Comment on lines
+644
to
+645
|
|
||
| // Grow the tree several times to check continued correct operation over lifetime of the log. |
Collaborator
There was a problem hiding this comment.
It feels like it should be possible to extract the stuff below out to a testonly.RunGCTest(t, ...) and make this be more of a black-box "all storages should behave consistently w.r.t. GC" type test.
We've talked in the past about perhaps coming at these sorts of things via a higher-level conformance suite which could run against the conformance binaries, maybe that's a better story.
Anyway, mostly just making a note here from the IRL conversations for posterity.
AlCutter
approved these changes
Dec 8, 2025
Collaborator
AlCutter
left a comment
AlCutter
left a comment
There was a problem hiding this comment.
Just a couple of little nits/questions.
storage/storage_test.go
Outdated
| @@ -0,0 +1,68 @@ | |||
| // Copyright 2024 The Tessera authors. All Rights Reserved. | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| // Copyright 2024 The Tessera authors. All Rights Reserved. | |
| // Copyright 2025 The Tessera authors. All Rights Reserved. |
storage/storage_test.go
Outdated
| content, err := os.ReadFile(path) | ||
| if err != nil { | ||
| t.Logf("Could not read %s: %v", path, err) | ||
| return nil // Don't fail the test if a file is unreadable, just skip |
storage/storage_test.go
Outdated
|
|
||
| // Check for the forbidden string | ||
| if strings.Contains(string(content), forbiddenName) { | ||
| t.Errorf("\n[FAIL] Found forbidden call '%s' in file: %s", forbiddenName, path) |
Collaborator
There was a problem hiding this comment.
This is an unusual looking log format string :)
- leading
\n - a
[FAIL]should automatically be generated for the test as a whole sinceErrorfwas called (albeit elsewhere in the log) %s-->%q
AlCutter
approved these changes
Dec 8, 2025
test WithGarbageCollectionInterval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug discovered while investigating transparency-dev/tesseract#644.
Before this PR, Tessera was using
layout.EntriesPath, but Tessera might have been configured to use a different path for entries.