Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/status-bar: fix aria-hidden warning #5663

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

Murderlon
Copy link
Member

Closes #5642

@Murderlon Murderlon self-assigned this Feb 25, 2025
Copy link
Contributor

Diff output files
diff --git a/packages/@uppy/status-bar/lib/StatusBarUI.js b/packages/@uppy/status-bar/lib/StatusBarUI.js
index 07a54f3..9ee577e 100644
--- a/packages/@uppy/status-bar/lib/StatusBarUI.js
+++ b/packages/@uppy/status-bar/lib/StatusBarUI.js
@@ -151,11 +151,13 @@ export default function StatusBarUI(_ref) {
   const atLeastOneAction = showUploadBtn || showRetryBtn || showPauseResumeBtn || showCancelBtn || showDoneBtn;
   const thereIsNothingInside = !atLeastOneAction && !progressBarStateEl;
   const isHidden = thereIsNothingInside || uploadState === STATE_COMPLETE && hideAfterFinish;
+  if (isHidden) {
+    return null;
+  }
   return h(
     "div",
     {
       className: statusBarClassNames,
-      "aria-hidden": isHidden,
     },
     h("div", {
       className: progressClassNames,

@Murderlon Murderlon merged commit 9930132 into main Feb 25, 2025
16 checks passed
@Murderlon Murderlon deleted the aria-hidden-warning branch February 25, 2025 12:47
github-actions bot added a commit that referenced this pull request Feb 25, 2025
| Package          | Version | Package          | Version |
| ---------------- | ------- | ---------------- | ------- |
| @uppy/companion  |   5.5.2 | @uppy/xhr-upload |   4.3.3 |
| @uppy/dashboard  |   4.3.2 | uppy             |  4.13.3 |
| @uppy/status-bar |   4.1.2 |                  |         |

- @uppy/dashboard: do not allow drag&drop of file preview (Merlijn Vos / #5650)
- @uppy/xhr-upload: fix when responseType is set to JSON (Merlijn Vos / #5651)
- meta: build(deps): bump akhileshns/heroku-deploy from 3.13.15 to 3.14.15 (dependabot[bot] / #5659)
- meta: build(deps): bump docker/build-push-action from 6.13.0 to 6.14.0 (dependabot[bot] / #5660)
- @uppy/status-bar: fix aria-hidden warning (Merlijn Vos / #5663)
- @uppy/companion: log when tus uploaded size differs (Mikael Finstad / #5647)
- @uppy/companion: remove redundant HEAD request for file size  (Mikael Finstad / #5648)
- meta: build(deps): bump elliptic from 6.6.0 to 6.6.1 (dependabot[bot] / #5649)
- examples: build(deps-dev): bump esbuild from 0.21.5 to 0.25.0 (dependabot[bot] / #5643)
- meta: build(deps-dev): bump vitest from 1.6.0 to 1.6.1 (dependabot[bot] / #5641)
- meta: build(deps): bump docker/setup-qemu-action from 3.3.0 to 3.4.0 (dependabot[bot] / #5640)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misuse of aria-hidden attribute
1 participant