fix google photos picker videos #5635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
would previously just download thumbnails
Diff output filesdiff --git a/packages/@uppy/provider-views/lib/GooglePicker/googlePicker.js b/packages/@uppy/provider-views/lib/GooglePicker/googlePicker.js
index abf47ed..62f568a 100644
--- a/packages/@uppy/provider-views/lib/GooglePicker/googlePicker.js
+++ b/packages/@uppy/provider-views/lib/GooglePicker/googlePicker.js
@@ -183,6 +183,7 @@ async function resolvePickedPhotos(_ref4) {
return mediaItems.map(_ref5 => {
let {
id,
+ type,
mediaFile: {
mimeType,
filename,
@@ -193,7 +194,7 @@ async function resolvePickedPhotos(_ref4) {
platform: "photos",
id,
mimeType,
- url: baseUrl,
+ url: type === "VIDEO" ? `${baseUrl}=dv` : baseUrl,
name: filename,
};
}); |
Murderlon
approved these changes
Feb 3, 2025
github-actions bot
added a commit
that referenced
this pull request
Feb 3, 2025
| Package | Version | Package | Version | | -------------------------- | ------- | -------------------------- | ------- | | @uppy/core | 4.4.2 | @uppy/provider-views | 4.4.2 | | @uppy/google-drive-picker | 0.3.3 | @uppy/url | 4.2.2 | | @uppy/google-photos-picker | 0.3.3 | @uppy/utils | 6.1.2 | | @uppy/locales | 4.5.1 | uppy | 4.13.2 | - @uppy/utils: do not strip www in getSocketHost (Merlijn Vos / #5621) - @uppy/url: skip drag/dropped local files (Merlijn Vos / #5626) - @uppy/provider-views: fix google photos picker videos (Mikael Finstad / #5635) - @uppy/core,@uppy/google-drive-picker,@uppy/google-photos-picker,@uppy/provider-views: fix google picker i18n (Mikael Finstad / #5632)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
would previously just download thumbnails