-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor VirtualList to typescript #5307
base: main
Are you sure you want to change the base?
Conversation
Diff output filesNo diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not our code, we're never going to upstream this change, so is this a good idea? If we want types, we could vendor https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/preact-virtual-list/index.d.ts
@aduh95, the original library has last been updated 8 years ago, we're effectively on our own now. I'm pro refactoring it into typescript & treating it like our own code. |
i'm open to switching to some module to do list virtualization, like for example https://tanstack.com/virtual/latest - however if we'ere going to instead keep our own implementation I think we should indeed refactor it to typescript |
Co-authored-by: Antoine du Hamel <[email protected]>
To be clear about my pending review - I'll review it when the performance part of this this PR ("VirtualList seems to be broken (fix it)") is implemented |
This reverts commit 5d331b9.
(cherry picked from commit 4f7e7d9)
Recreated #5255 because that one became messed up after google drive merge to main
TODO