everywhere - clear file input value using an '' instead of null

transloadit · Aug 1, 2024 · 536bfc9 · 536bfc9
1 parent f76d744
commit 536bfc9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/packages/@uppy/dashboard/src/components/AddFiles.tsx b/packages/@uppy/dashboard/src/components/AddFiles.tsx
@@ -40,7 +40,8 @@ class AddFiles extends Component {
     // ___Why not use value="" on <input/> instead?
     //    Because if we use that method of clearing the input,
     //    Chrome will not trigger change if we drop the same file twice (Issue #768).
-    event.target.value = null // eslint-disable-line no-param-reassign
+    // eslint-disable-next-line no-param-reassign
+    ;(event.target as HTMLInputElement).value = ''
   }
 
   private renderHiddenInput = (isFolder: $TSFixMe, refCallback: $TSFixMe) => {

diff --git a/packages/@uppy/drag-drop/src/DragDrop.tsx b/packages/@uppy/drag-drop/src/DragDrop.tsx
@@ -93,9 +93,8 @@ export default class DragDrop<M extends Meta, B extends Body> extends UIPlugin<
     // ___Why not use value="" on <input/> instead?
     //    Because if we use that method of clearing the input,
     //    Chrome will not trigger change if we drop the same file twice (Issue #768).
-    // @ts-expect-error TS freaks out, but this is fine
     // eslint-disable-next-line no-param-reassign
-    event.target.value = null
+    ;(event.target as HTMLInputElement).value = ''
   }
 
   private handleDragOver = (event: DragEvent) => {

diff --git a/packages/@uppy/file-input/src/FileInput.tsx b/packages/@uppy/file-input/src/FileInput.tsx
@@ -76,8 +76,8 @@ export default class FileInput<M extends Meta, B extends Body> extends UIPlugin<
     // ___Why not use value="" on <input/> instead?
     //    Because if we use that method of clearing the input,
     //    Chrome will not trigger change if we drop the same file twice (Issue #768).
-    // @ts-expect-error yes
-    event.target.value = null // eslint-disable-line no-param-reassign
+    // eslint-disable-next-line no-param-reassign
+    ;(event.target as HTMLInputElement).value = ''
   }
 
   private handleClick() {