Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Victory by capturing one of enemy flags when the timer is activated #2104

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TerminalHash
Copy link
Contributor

Status

  • READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

In our captains mod, Gruhsha CTF, we using vanilla match timer, i was surprised there was no code written for when one of the enemy's flags was captured and the timer activated. I don't know if anyone else would play with the timer on, but why not?

Future plans are to write overtime conditions for when one of the flags is captured and match time has expired, but at another time.

Steps to Test or Reproduce

  1. Enable match timer in CTF.as by editing this line (editing ctf_vars.cfg is not working for this):
    s32 gameDurationMinutes = cfg.read_s32("game_time", -1);
  2. Cap one flag from enemy team
  3. Wait, when timer will be ended

Copy link
Member

@Vam-Jam Vam-Jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature works, lgtm, just fix the comment indent

Anybody else wanting to test can do so by running /rcon getRules().set_u32('game_end_timer', 30 * 60 * 1); getRules().set_bool('no timer', false);

Rules/CTF/Scripts/CTF.as Outdated Show resolved Hide resolved
@Vam-Jam Vam-Jam added change A change to an existing feature or mechanic ready A pull request that functions correctly and is ready for testing labels Sep 2, 2024
Rules/CTF/Scripts/CTF.as Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change A change to an existing feature or mechanic ready A pull request that functions correctly and is ready for testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants