Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoreboard fixes #2097

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Scoreboard fixes #2097

merged 2 commits into from
Sep 2, 2024

Conversation

TerminalHash
Copy link
Contributor

Status

  • READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

Map names, team names on ru language and match timer broken after this commit: a32a461

This pull request fixing this.

Steps to Test or Reproduce

Join on vanilla CTF or host local dedicated server with CTF mode, use locale RU and open scoreboard.

@Vam-Jam Vam-Jam added the fix Fixes a bug label Sep 2, 2024
Vam-Jam
Vam-Jam requested changes Sep 2, 2024
View reviewed changes
Copy link
Member

@Vam-Jam Vam-Jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

After:

Match timer now only increments after the game has started, which seems to be how the script should have worked before it was broken.

lgtm after the comments are fixed

Rules/CommonScripts/ScoreboardCommon.as Outdated Show resolved Hide resolved
Rules/CommonScripts/ScoreboardRender.as Outdated Show resolved Hide resolved
@Vam-Jam Vam-Jam added the ready A pull request that functions correctly and is ready for testing label Sep 2, 2024
@asumagic asumagic merged commit fda2bd2 into transhumandesign:master Sep 2, 2024
@Vam-Jam Vam-Jam linked an issue Sep 4, 2024 that may be closed by this pull request
Map timer is broken in scoreboard #2055
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vam-Jam Vam-Jam Vam-Jam approved these changes

Assignees
No one assigned
Labels
fix Fixes a bug ready A pull request that functions correctly and is ready for testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map timer is broken in scoreboard
3 participants
@TerminalHash @Vam-Jam @asumagic