Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fixed] Builder Queued Hit Fix #2069

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[fixed] Builder Queued Hit Fix #2069

wants to merge 2 commits into from

Conversation

mehwaffle10
Copy link

Status

  • READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

New logic for queued hits in BuilderLogic.as does not function, causing builders to periodically not break blocks.

Safe reading a CBitStream after the onCommand hook fails, always reading the values in onCommand and caching them instead of the CBitStream fixes the issue.

Mentioned in issue #2065

Steps to Test or Reproduce

  1. Swap to builder
  2. Continually break blocks until a swing does not register

@mehwaffle10
Builder Queued Hit Fix
1bc6ed2 
Safe reading a CBitStream after the onCommand hook fails, always reading the values in onCommand and caching them instead of the CBitStream fixes the issue
@mugg91
Copy link
Contributor

mugg91 commented Jun 4, 2024

When is this going to get implemented?
The pickaxe missing every 3rd hit is serious. I was under the impression a hotfix was going to be released soon.

@mehwaffle10 mehwaffle10 changed the title Builder Queued Hit Fix [fixed] Builder Queued Hit Fix Jun 14, 2024
TerminalHash added a commit to TerminalHash/Gruhsha-CTF that referenced this pull request Aug 8, 2024
@TerminalHash
merge mehwaffle's pickaxe fix
d5e75ab 
pull request for kag-base: transhumandesign/kag-base#2069
@Vam-Jam Vam-Jam self-requested a review September 2, 2024 15:49
Vam-Jam
Vam-Jam requested changes Sep 2, 2024
View reviewed changes
Copy link
Member

@Vam-Jam Vam-Jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR functions correctly, no longer skipping random hits. Has been tested by other people in CTF servers.

Fix indents, otherwise it looks good

Entities/Characters/Builder/BuilderLogic.as Outdated Show resolved Hide resolved
Entities/Characters/Builder/BuilderLogic.as Outdated Show resolved Hide resolved
Entities/Characters/Builder/BuilderLogic.as Outdated Show resolved Hide resolved
@Vam-Jam Vam-Jam added the fix Fixes a bug label Sep 2, 2024
@Vam-Jam Vam-Jam added this to the post-4762 milestone Sep 3, 2024
@mehwaffle10
Update BuilderLogic.as
e18ceea 
Spacing. Due to VS code replacing tabs with 4 spaces
@Vam-Jam Vam-Jam added the ready A pull request that functions correctly and is ready for testing label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vam-Jam Vam-Jam Vam-Jam approved these changes

Assignees
No one assigned
Labels
fix Fixes a bug ready A pull request that functions correctly and is ready for testing
Projects
None yet
Milestone
Next Patch
Development

Successfully merging this pull request may close these issues.
3 participants
@mehwaffle10 @mugg91 @Vam-Jam