Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fixed] fix stun, when you jumping on trampoline #2063

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[fixed] fix stun, when you jumping on trampoline #2063

wants to merge 2 commits into from

Conversation

TerminalHash
Copy link
Contributor

@TerminalHash TerminalHash commented May 4, 2024 •
edited
Loading

Status

  • READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

In the standard situation, when trying to jump on a trampoline for a while, the player gets a stun:
https://github.com/transhumandesign/kag-base/assets/64691722/5728a98d-23bc-4a13-99f9-62967c078928

With the fix, the player will no longer get stun from jumping on the trampoline (including from a lower height)
https://github.com/transhumandesign/kag-base/assets/64691722/22156bef-395f-4181-9d91-003d8e8e8a47

Steps to Test or Reproduce

  1. Build a small pillar of blocks upwards
  2. Put the trampoline underneath
  3. Climb the pole and jump from it onto the trampoline
  4. ...
  5. STUN!

Vam-Jam
Vam-Jam requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@Vam-Jam Vam-Jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format the if statement to match, otherwise the code works fine and not found any bugs

Entities/Common/Movement/FallDamage.as Outdated Show resolved Hide resolved
@Vam-Jam Vam-Jam added the fix Fixes a bug label Sep 3, 2024
@TerminalHash
Copy link
Contributor Author

done

@Vam-Jam Vam-Jam added the ready A pull request that functions correctly and is ready for testing label Sep 3, 2024
Vam-Jam
Vam-Jam previously approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@Vam-Jam Vam-Jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vam-Jam Vam-Jam added this to the post-4762 milestone Sep 3, 2024
@TerminalHash TerminalHash changed the title [fix] fix stun, when you jumping on trampoline [fixed] fix stun, when you jumping on trampoline + add github accolade for TerminalHash Sep 6, 2024
@TerminalHash TerminalHash changed the title [fixed] fix stun, when you jumping on trampoline + add github accolade for TerminalHash [fixed] fix stun, when you jumping on trampoline Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vam-Jam Vam-Jam Vam-Jam approved these changes

Assignees
No one assigned
Labels
fix Fixes a bug ready A pull request that functions correctly and is ready for testing
Projects
None yet
Milestone
Next Patch
Development

Successfully merging this pull request may close these issues.
2 participants
@TerminalHash @Vam-Jam