[fixed] Spiker and Dispenser will work with away-facing Platforms at their exit #2026
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
Fixes #1979
Previously, Spiker and Dispenser would not work if a Platform was placed at their exit. Since it looked odd that they wouldn't work even with away-facing platforms, I made this PR to make changes.
The
CollidesWithPlatform()
code from #1864 is used, this time separated in a new filePlatformCommon.as
and added as an include inSpiker.as
andDispenser.as
.To make the ray correctly detect the platform, start position
position + offset * map.tilesize/2;
is used instead ofposition + offset * 5;
Previously, Dispenser would make a particle and sound without popping out item if its exit is blocked.
I changed it to not make the particle to better indicate that it is blocked.
Tested in offline. Should work the same in online.
Blocked by bridge
but it works if it is opened (since it is non-solid)