Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fixed] Tip on death will look better #2023

Merged
merged 2 commits into from
Sep 6, 2024
Merged

[fixed] Tip on death will look better #2023

merged 2 commits into from
Sep 6, 2024

Conversation

mugg91
Copy link
Contributor

@mugg91 mugg91 commented Apr 17, 2024

Status

  • READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

[fixed] Tip was not correctly centered inside its button
[changed] DrawButtonPressed() is used instead of DrawButton()
[added] Tips will hover up and down slowly

Fixes #2017

This PR makes tips look better.

Steps to Test or Reproduce

Die and look at the tip.

Gingerbeard5773
Gingerbeard5773 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@Gingerbeard5773 Gingerbeard5773 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as intended. I definitely like the new look. good job

Vam-Jam
Vam-Jam approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@Vam-Jam Vam-Jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works from testing.

@Vam-Jam Vam-Jam added ready A pull request that functions correctly and is ready for testing fix Fixes a bug labels Sep 3, 2024
@Vam-Jam Vam-Jam added this to the post-4762 milestone Sep 3, 2024
@asumagic asumagic merged commit b9730a7 into transhumandesign:master Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vam-Jam Vam-Jam Vam-Jam approved these changes

@Gingerbeard5773 Gingerbeard5773 Gingerbeard5773 approved these changes

Assignees
No one assigned
Labels
fix Fixes a bug ready A pull request that functions correctly and is ready for testing
Projects
None yet
Milestone
Next Patch
Development

Successfully merging this pull request may close these issues.

Tip isn't displayed inside the text box correctly
4 participants
@mugg91 @Vam-Jam @Gingerbeard5773 @asumagic