[fixed] You can't use buttons while stunned anymore

[mugg91]

Status

• READY: this PR is (to the best of your knowledge) ready to be incorporated into the game.

Description

[fixed] that you could show "key_use" buttons while stunned
[fixed] that you could keep showing buttons, get stunned and then use them

Fixes #1951
Fixes #1028

I first noticed this problem in TDM. I was stunned due to falling from a height but was still able to open a chest without delay. This shouldn't be possible, so...

Preventing the player from showing new buttons

This PR adds a check to canSeeButtons() in GenericButtonCommon.as to see if the player is stunned (= knocked).
If the player is stunned, he won't be able to show any blob buttons by using "key_use".
Luckily this seems to work for inventory buttons, too. As far as I understand they are server-handled.
I wasn't able to access inventories after applying this fix.

Removing already existing buttons

Inside DoKnockedUpdate() in KnockedCommon.as, I added:

if (this.isMyPlayer())
{
	this.ClearButtons();
	this.ClearMenus();
}

This causes buttons that already existed due to keeping "key_use" pressed to exit while the player is stunned.

Now the player can't manage inventories, change class or use tunnels while stunned anymore.

Tested in offline and online, works as intended.

Steps to Test or Reproduce

Be a knight, /coins 999, spawn a knightshop and buy a bunch of waterbombs.
Go to a chest, tent, storage or tunnel (when there are at least 2).
Throw a waterbomb above you.
Try to press or keep pressed the key_use key in order to show or keep showing buttons for above mentioned blobs, before or after getting hit by the waterbomb.
Notice you will be able to show and use buttons while stunned.
After this PR, you won't be able to.

[mugg91]

I noticed this old issue #1028

This PR already fixes the issue but the inventory screen would open for 1 tick with each key_inventory press while stunned.
I added a commit that will make it so it doesn't open at all during stun.

Fixes the above-mentioned issue.

[Gingerbeard5773]

Tested and works as intended.

[Vam-Jam]

Works fine, will leave this open for discussion for now as it does close #1028, which some people may see as a feature that should not be removed (?)

[Vam-Jam]

Push the include up one line