Skip to content

Optimise deleteByTypeAndClient method #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
daveking-tw wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Optimise deleteByTypeAndClient method #43

daveking-tw wants to merge 4 commits into from

Conversation

@daveking-tw
Copy link
Contributor

@daveking-tw daveking-tw commented Apr 29, 2022 •
edited
Loading

❓ Context

On applications with large idempotent_action tables, deleteByTypeAndClient can be optimised by removing the need to sort actions before delete

🚀 Changes

  • add index definition for deleteByTypeAndClient queries
  • removed sort in deleteByTypeAndClient queries to let db return/delete records in natural order without the overhead of sorting

Considerations

Actions will no longer be deleted oldest first

@daveking-tw daveking-tw changed the title Tune deleteByTypeAndClient Tune deleteByTypeAndClient method Apr 29, 2022
@daveking-tw daveking-tw changed the title Tune deleteByTypeAndClient method Optimise deleteByTypeAndClient method Apr 29, 2022
phildobsontw
phildobsontw reviewed Apr 29, 2022
View reviewed changes
...ources/db/idempotence4j/mariadb/V20220429110000__add_idempotent_action_type_client_index.sql
@@ -0,0 +1,2 @@
CREATE INDEX IF NOT EXISTS IDX_IDEMPOTENT_ACTION_TYPE_CLIENT
Copy link
Contributor

@phildobsontw phildobsontw Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just googling to see if there's a mariadb equivalent of concurrently - looks like adding ALGORITHM=INPLACE LOCK=NONE may do the trick?

phildobsontw
phildobsontw reviewed Apr 29, 2022
View reviewed changes
...ariadb/src/main/java/com/transferwise/idempotence4j/mariadb/JdbcMariaDbActionRepository.java
"DELETE FROM idempotent_action " +
"WHERE type = :type " +
" AND client = :client " +
"ORDER BY created_at ASC " +
Copy link
Contributor

@phildobsontw phildobsontw Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a good spot - it's not necessary for this to be deterministic!

phildobsontw
phildobsontw approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@phildobsontw phildobsontw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🚀

@MatthewStocks
Copy link

MatthewStocks commented Jan 26, 2026

/wise-bot sync-codeowners

@wise-github-bot-app
Copy link

wise-github-bot-app bot commented Jan 26, 2026

These are all the things I can do:

approve: Creates synthetic approvals for retrospective reviews.
emergency-merge: This command no longer exists. Please use a different emergency merge command.
incident-merge: Merges the PR even with failed checks. Use only under during live Incidents.
misc-emergency-merge: Merges the PR even with failed checks. Use only when other emergency merge options do not satifsy the use case.
broken-config-merge: Merges the PR even with failed checks. Use only when CODEOWNERS or tw-rules are broken.
multi-codeowners-merge: Emergency merges a PR in a repository with multiple CODEOWNERS when getting all reviews takes too long. Requires approval from a default repository owner and at least 3 other approvals from teams in CODEOWNERS.
ping: Check if the bot is properly listening
run-checks: Runs all checks in the PR. Use it if the automatic run was buggy
run-action: Forces a specific action to run
org-oidc: Opt in or out of Wise OIDC schema

@MatthewStocks
Copy link

MatthewStocks commented Jan 26, 2026

/wise-bot run-action sync-codeowners

@wise-github-bot-app
Copy link

wise-github-bot-app bot commented Jan 26, 2026

🔴

No CODEOWNERS file was found in your repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phildobsontw phildobsontw phildobsontw approved these changes

@pturovsk pturovsk pturovsk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daveking-tw @MatthewStocks @phildobsontw @pturovsk