CONNECT-2370: Update protos in envoy api #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comment
You can also request review from a specific team by commenting 💡 If you see something that doesn't look right, check the configuration guide. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Envoy protobuf definitions as part of an Envoy upgrade to version 1.34.4. The changes span across numerous service definitions, transport sockets, filters, and configurations, representing a comprehensive update to the Envoy API surface.
Key changes include:
- Updated Envoy SHA hash in API_SHAS file to track the new version
- Added new services including Redis external authentication and network external processing
- Enhanced existing filters with new configuration options and features
- Updated documentation and field descriptions throughout
Reviewed Changes
Copilot reviewed 130 out of 132 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/API_SHAS | Updated Envoy SHA hash to track version 1.34.4 |
| envoy/type/v3/http_status.proto | Added documentation comments for all HTTP status code enum values |
| envoy/type/matcher/v3/filter_state.proto | Added address matcher support with new import and field |
| envoy/type/matcher/v3/address.proto | New file defining AddressMatcher message for IP/CIDR matching |
| envoy/service/trace/v*/trace_service.proto | Removed deprecated trace service definitions |
| envoy/service/status/v3/csds.proto | Added CLIENT_RECEIVED_ERROR status for control plane errors |
| envoy/service/redis_auth/v3/redis_external_auth.proto | New Redis external authentication service definition |
| envoy/service/ratelimit/v3/rls.proto | Added WEEK time unit and hits_addend filter state documentation |
| envoy/service/network_ext_proc/v3/network_external_processor.proto | New network-level external processing service |
| envoy/service/ext_proc/v3/external_processor.proto | Enhanced with protocol configuration and streaming support |
| envoy/service/discovery/v3/discovery.proto | Added resource error reporting capabilities |
| Multiple extension files | Various enhancements including new filters, transport sockets, and configuration options |
Comments suppressed due to low confidence (1)
src/main/proto/envoy/extensions/geoip_providers/common/v3/common.proto:25
- [nitpick] The comment should use proper grammar: "This field is deprecated; use
anoninstead." or "This field is being deprecated; useanoninstead."
string country = 1
src/main/proto/envoy/extensions/filters/http/proto_message_extraction/v3/config.proto
Show resolved
Hide resolved
niting3c
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Part of envoy upgrade to 1.34.4
https://transferwise.atlassian.net/jira/software/projects/CONNECT/boards/1112?selectedIssue=CONNECT-2370
Checklist