esbuild #229
esbuild #229
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| export default WebpackWorker; | ||
| class PenumbraWebWorker extends Worker {} | ||
| export default PenumbraWebWorker; | ||
| } |
There was a problem hiding this comment.
not in use - can delete
| @@ -178,7 +178,7 @@ function save( | |||
| 'stream' in files ? (files as unknown as PenumbraFile) : files[0]; | |||
| const [ | |||
| filename, | |||
| extension = file.mimetype ? mime.extension(file.mimetype) : '', | |||
| extension = file.mimetype ? `.${getExtension(file.mimetype)}` : '', | |||
There was a problem hiding this comment.
lighter mime type lib meant for browsers. also noticed neither library returns with a . prefix which would result in imagepng
| @@ -8,6 +8,5 @@ export { default as getTextFromRS } from './getTextFromRS'; | |||
| export { default as toBuff } from './toBuff'; | |||
| export { default as blobCache } from './blobCache'; | |||
| export { default as isViewableText } from './isViewableText'; | |||
| export { default as intoStream } from './intoStream'; | |||
There was a problem hiding this comment.
Unused + is the only thing depending on web-streams-node, so we can drop it and the npm lib (which itself requires a bunch of polyfills to support)
|
These changes don't deprecate setWorkerLocation just yet. I think we can save that for 6.1 |
where do I change the code that's calling build:example?
|
@bencmbrook Where do I change the code that is calling |
|
@bencmbrook thanks; I'll get this unblocked & ready for review by EOW |
|
@eligrey updated that vercel build script to |
src/workers.ts
Outdated
| penumbra: '/worker.penumbra.js', | ||
| penumbra: 'worker.penumbra.js', |
There was a problem hiding this comment.
@eligrey is this change ok? I've seen it go back and forth in this PR. With the / the worker 404s in the example
Alt to #226 with esbuild only
Related Issues
Public Changelog
[none]
Security Implications
[none]