feat: add ability to set or unset the CLIENT_FOUND_ROWS flag#4334
Open
andreastedile wants to merge 1 commit into
Open
feat: add ability to set or unset the CLIENT_FOUND_ROWS flag#4334andreastedile wants to merge 1 commit into
andreastedile wants to merge 1 commit into
Conversation
9da8ce5 to
326ae3c
Compare
326ae3c to
23f34f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3063.
Is this a breaking change?
No: it preserves current SQLx behavior.
Context
We are developing an application with "upsert" (update or insert) semantics: each request should either update an existing row or insert a new one if no matching row exists.
To implement this behavior, we use MySQL statements of the form INSERT ... ON DUPLICATE KEY UPDATE:
https://dev.mysql.com/doc/refman/8.4/en/insert-on-duplicate.html
SQLx currently enables the MySQL CLIENT_FOUND_ROWS flag by default:
https://github.com/transact-rs/sqlx/blob/main/sqlx-mysql/src/connection/stream.rs#L38
which makes it impossible to distinguish whether a row was inserted as a new row or set to its current values,
because in both cases MySQL reports affected_rows = 1 when CLIENT_FOUND_ROWS is enabled.
This PR preserves current SQLx behavior, as the
found_rowsvariable is set to true by default.