Preserve topology while rounding area vertex coordinates before MC #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! |
|
I released TrakEM2 v1.3.10 including this change, and updated the version in pom-scijava (scijava/pom-scijava@fb96bdb). The next release of Fiji, planned for later this winter, will include it. |
|
Awesome, thank you!
…On Thu, 18 Jan 2024, 21:05 Curtis Rueden, ***@***.***> wrote:
I released TrakEM2 v1.3.10
<https://maven.scijava.org/#nexus-search;gav~sc.fiji~TrakEM2_~1.3.10~~>
including this change, and updated the version in pom-scijava (
***@***.***
<scijava/pom-scijava@fb96bdb>).
The next release of Fiji, planned for later this winter, will include it.
—
Reply to this email directly, view it on GitHub
<#36 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMKGSC474TYMNVQ32JQSTYPGFAVAVCNFSM6AAAAABCAZMZROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZGIYDEMRRGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While preparing for marching cubes run, areas are transformed and then their vertex coordinates are rounded to integers. However, the current implementation ignores polygon winding. This effectively results in filled holes.
I suggest to use Path2D to accomplish this.