Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup
Download https://alt.org/nethack/xlogfile.full.txt
Run this script like:
python mk-nethack.py --generate --benchmark --name <name> /path/to/xlogfile.full.txt
--generate
Creates a new tdb from the nethack log named<name>.tdb
(Not included in benchmark timing)The input can be passed as a file path or piped in from stdin.
eg.
head -1000 /path/to/xlogfile.full.txt | python mk-nethack.py --generate --name sample
--benchmark
Runs the benchmark on<name>.tdb
The Benchmark
The nethack data has a bunch of causes of death in the
death
field.eg,
We take the first word (Usually a verb) and track the average number of
points
for that death.The Results
On the full nethack data, this takes about 2 minutes 20 seconds on master and about 48s using the #21 perf-improvements branch.