Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix priceLine rendering when having LastPriceAnimation indicator #1737

Conversation

signatenkov
Copy link
Contributor

Type of PR: bugfix

PR checklist:

Note:

  • Not adding an e2e graphics test case because it is unreliable to test the Last Price Animation during it the timing of the screenshot within the animation effect.

Copy link

size-limit report 📦

Path Size
ESM 42.31 KB (-0.06% 🔽)
ESM createChart 36.3 KB (+0.07% 🔺)
ESM createChartEx 35.07 KB (+0.04% 🔺)
ESM Standalone 43.78 KB (+0.11% 🔺)
Standalone 43.77 KB (+0.09% 🔺)
Plugin: Text Watermark 1.86 KB (0%)
Plugin: Image Watermark 1.68 KB (0%)
Plugin: Series Markers 3.89 KB (0%)
Series: LineSeries 2.54 KB (0%)
Series: BaselineSeries 3.05 KB (0%)
Series: AreaSeries 2.98 KB (0%)
Series: BarSeries 2.14 KB (0%)
Series: CandlestickSeries 2.43 KB (0%)
Series: HistogramSeries 2.2 KB (0%)

@SlicedSilver SlicedSilver added the bug Unexpected problem or unintended behavior. label Nov 21, 2024
@SlicedSilver SlicedSilver added this to the 5.0 milestone Nov 21, 2024
@SlicedSilver SlicedSilver self-requested a review November 21, 2024 12:26
@signatenkov signatenkov merged commit b059b29 into v5-candidate Nov 22, 2024
32 of 33 checks passed
@signatenkov signatenkov deleted the lastpriceanimation_indicator_overlaps_priceLine_axis_label_v5 branch November 22, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LastPriceAnimation indicator overlaps priceLine axis label
2 participants