Update to latest master + unselected color + pod/spm support #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to place subviews onto UITableViewCell's contentView (to use `UITableViewCell.insetsContentViewsToSafeArea`).
by swift 4.1 syntax * UIColor.whiteColor() -> UIColor.white * UIFont.systemFontOfSize(18) -> UIFont.systemFont(ofSize: 18)
by swift 4.1 syntax * UIView.animate * CGAffineTransform
e.g. missing commas, verb tense correction, and the like.
BaseButtonBarPagerTabStripViewController.buttonBarView.selectedBarVerticalAlignment did not respect the settings in the style. This meant that any subclasses of BaseButtonBarPagerTabStripViewController could not change the vertical alignment of the selected bar.
Prefer the indicatorInfo's accessibilityLabel
Add UIKit import as it creates a compile time error
|
As a better approach we may use another branch https://github.com/trading-point/XLPagerTabStrip/tree/fork_from_original for the same reasons, consisting of the exact same changes. The only difference will be in the commit structure, that is easier to follow: with the latest original |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes
Reasons
Results