Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Add ability to ignore missing fields #830

Closed
wants to merge 1 commit into from

Conversation

lekoala
Copy link
Contributor

@lekoala lekoala commented Mar 20, 2024

Description

SHOW FULL FIELDS are costly queries. Maybe it's not necessary to do this on every request

Manual testing steps

Using debugbar, you can check the queries
With this new feature, this prevents all queries: SHOW FULL FIELDS IN xxx

Issues

#828

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@tractorcow
Copy link
Collaborator

The fix I've proposed at #831 is better since it precisely enables the check only when necessary, rather than relying on the site owner to manually enable it.

@tractorcow
Copy link
Collaborator

@lekoala can you let me know if you are happy for me to merge my fix over yours?

@lekoala
Copy link
Contributor Author

lekoala commented Mar 21, 2024

@tractorcow yes please do :-) your approach is better

@tractorcow
Copy link
Collaborator

Fixed with #831

@tractorcow tractorcow closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants