API Standardise extension hooks (#873)

tractorcow-farm · Aug 27, 2024 · 0f14408 · 0f14408
1 parent e23ece0
commit 0f14408
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/Extension/FluentIsolatedExtension.php b/src/Extension/FluentIsolatedExtension.php
@@ -69,7 +69,7 @@ protected function augmentDatabase()
         }
     }
 
-    public function requireDefaultRecords()
+    protected function onRequireDefaultRecords()
     {
         // Migrate records that used to be FluentFilteredExtension
         $this->migrateFromFilteredExtension();

diff --git a/src/Extension/FluentLeftAndMainExtension.php b/src/Extension/FluentLeftAndMainExtension.php
@@ -21,7 +21,7 @@ class FluentLeftAndMainExtension extends Extension
     use FluentAdminTrait;
     use FluentBadgeTrait;
 
-    public function init()
+    protected function onInit()
     {
         Requirements::javascript("tractorcow/silverstripe-fluent:client/dist/js/fluent.js");
         Requirements::css("tractorcow/silverstripe-fluent:client/dist/styles/fluent.css");

diff --git a/src/Extension/FluentSiteTreeExtension.php b/src/Extension/FluentSiteTreeExtension.php
@@ -44,7 +44,7 @@ class FluentSiteTreeExtension extends FluentVersionedExtension
      *
      * @param string &$tags
      */
-    public function MetaTags(&$tags)
+    protected function updateMetaTags(&$tags)
     {
         $tags .= $this->owner->renderWith('FluentSiteTree_MetaTags');
     }
@@ -80,7 +80,7 @@ public function getLinkToXDefault()
      * @param string &$base
      * @param string &$action
      */
-    public function updateRelativeLink(&$base, &$action)
+    protected function updateRelativeLink(&$base, &$action)
     {
 
         if ($this->owner->hasMethod('disablePrependLocaleURLSegmentToLink') && $this->owner->disablePrependLocaleURLSegmentToLink()) {
@@ -132,7 +132,7 @@ public function updateRelativeLink(&$base, &$action)
      * @param string $action
      * @param string $relativeLink
      */
-    public function updateLink(&$link, &$action, &$relativeLink)
+    protected function updateLink(&$link, &$action, &$relativeLink)
     {
         // Get appropriate locale for this record
         $localeObj = $this->getRecordLocale();

diff --git a/src/Extension/FluentVersionedExtension.php b/src/Extension/FluentVersionedExtension.php
@@ -502,7 +502,7 @@ protected function isLocalisedInStage($stage, $locale = null)
     /**
      * Clear internal static property caches
      */
-    public function flushCache()
+    protected function onFlushCache()
     {
         static::reset();
     }