fix(sdk): log errors from Fetcher.api_post instead of printing to stdout#4344
Open
CAN-Aidoo wants to merge 1 commit into
Open
fix(sdk): log errors from Fetcher.api_post instead of printing to stdout#4344CAN-Aidoo wants to merge 1 commit into
CAN-Aidoo wants to merge 1 commit into
Conversation
Fetcher.api_post caught exceptions and called print(e), which bypassed the log stream, dropped all context (endpoint name, no traceback), and wrote to stdout. Every other error path in fetcher.py already uses logging.error(...). Switch to logging.error with the endpoint name so failures surface in log aggregators and respect log-level filtering.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe exception handler in ChangesFetcher error handling
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
print(e)inFetcher.api_postwithlogging.error(\"Failed to post to %s: %s\", api, e).Motivation
Every other error path in
fetcher.pyuseslogging.error(...)— see lines 108, 111, 143. Theprint(e)inapi_postwas the odd one out:The other
print(...)calls intraceloop/sdk/__init__.py,tracing.py, andexperiment/*are intentional colorama-styled user-facing startup output and are out of scope.Test plan
tests/test_fetcher_logging.pyasserts an ERROR record is emitted through the log stream with the endpoint name in the formatted message, and that stdout stays silent.uv run ruff checkpasses on the modified files.Summary by CodeRabbit