Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(azureai-search) #2319

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(azureai-search) #2319

wants to merge 2 commits into from

Conversation

Mr-Imperium
Copy link

Added support for Azure search
Fixes #2303

  • [X ] I have added tests that cover my changes.
  • [X ] PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • [X ] (If applicable) I have updated the documentation accordingly.

@Mr-Imperium
Fix traceloop#2303
fd4845d 
Added support for Azure search
Fixes traceloop#2303
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 19, 2024
@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added python Pull requests that update Python code testing labels Nov 19, 2024
nirga
nirga reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mr-Imperium thanks for this - but have you tried running this? You're referencing non existing classes within the otel SDK, and it doesn't even look like an instrumentation (see other examples we have in the repo). What were you trying to do here? 🤔

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirga nirga Awaiting requested review from nirga

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
python Pull requests that update Python code size:XL This PR changes 500-999 lines, ignoring generated files. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Support for Azure AI Search
3 participants
@Mr-Imperium @CLAassistant @nirga