feat(otel): general bump to v2

[nirga]

Important

Update OpenTelemetry dependencies to v2 and adjust test setups across multiple packages.

• Dependencies:
  • Update @opentelemetry/core to ^2.0.1 in package.json files for multiple packages.
  • Update @opentelemetry/instrumentation to ^0.202.0 in package.json files for multiple packages.
  • Update @opentelemetry/semantic-conventions to ^1.34.0 in package.json files for multiple packages.
• Test Setup:
  • Replace BasicTracerProvider with NodeTracerProvider in test files such as instrumentation.test.ts for packages like instrumentation-anthropic, instrumentation-azure, and others.
  • Modify test setup to use NodeTracerProvider with spanProcessors in before hooks.
• Miscellaneous:
  • Update resource initialization to use resourceFromAttributes in sample_otel_sdk.ts and index.ts.
  • Replace baggageUtils.parseKeyPairsIntoRecord with parseKeyPairsIntoRecord in index.ts and span-processor.ts.

^{This description was created by for 70e2e18. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to bfb1649 in 44 seconds. Click for details.

• Reviewed 217 lines of code in 13 files
• Skipped 1 files when reviewing.
• Skipped posting 2 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. packages/instrumentation-anthropic/package.json:40

• Draft comment:
  Bump opentelemetry deps to v2 (core: ^2.0.1, instrumentation: ^0.202.0, semantic-conventions: ^1.34.0). Ensure any breaking API changes in OTEL v2 are handled.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is related to dependency changes, specifically bumping the version of opentelemetry dependencies. It also asks to ensure that any breaking API changes are handled, which is a form of asking the author to double-check something. This violates the rules against commenting on dependency changes and asking for confirmation or double-checking.

2. packages/traceloop-sdk/package.json:38

• Draft comment:
  Update OTEL exporter and sdk-node versions to ^0.202.0. Verify that SDK integrations are compatible with OTEL v2 changes.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify compatibility with a new version of a dependency, which is against the rules. It doesn't provide a specific suggestion or point out a specific issue with the code.

Workflow ID: wflow_VInpx3opX220rtLU

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed d430427 in 1 minute and 56 seconds. Click for details.

• Reviewed 992 lines of code in 33 files
• Skipped 1 files when reviewing.
• Skipped posting 5 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. packages/traceloop-sdk/src/lib/tracing/span-processor.ts:88

• Draft comment:
  There's a potential naming mismatch in the instrumentation libraries array. The array includes "@traceloop/instrumentation-chroma" but the actual package name appears to be "@traceloop/instrumentation-chromadb". Consider updating this for consistency.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. packages/traceloop-sdk/src/lib/tracing/span-processor.ts:6

• Draft comment:
  The imported constant is named 'ASSOCATION_PROPERTIES_KEY' but it appears to be a typo; likely it should be 'ASSOCIATION_PROPERTIES_KEY'. Confirm and update if necessary.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. packages/traceloop-sdk/src/lib/tracing/span-processor.ts:158

• Draft comment:
  In the onSpanEnd function, the span’s name is being reassigned via a cast to 'any'. While noted as a workaround, modifying immutable span names might have unintended side effects. Consider revisiting or documenting this approach.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. packages/traceloop-sdk/src/lib/tracing/span-processor.ts:197

• Draft comment:
  The JSON.parse for the attribute 'ai.prompt.messages' is wrapped in a try/catch that silently ignores errors. Logging a warning could aid in debugging if the expected JSON format isn’t met.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

5. packages/instrumentation-pinecone/test/instrumentation.test.ts:34

• Draft comment:
  Typo: The string "pincone-instrumentation-test" in the constant PINECONE_TEST_INDEX appears to have a misspelling. Consider using "pinecone-instrumentation-test".
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_OyMSaqcY7uCL2zlH

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed dfa9bd7 in 1 minute and 22 seconds. Click for details.

• Reviewed 1016 lines of code in 34 files
• Skipped 1 files when reviewing.
• Skipped posting 5 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. packages/traceloop-sdk/src/lib/tracing/span-processor.ts:110

• Draft comment:
  The allowed instrumentation libraries array contains "@traceloop/instrumentation-chroma", but the file imports ChromaDBInstrumentation from "@traceloop/instrumentation-chromadb". Ensure naming consistency between the package name and allowed instrumentation string.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. packages/traceloop-sdk/src/lib/tracing/span-processor.ts:12

• Draft comment:
  The constant imported as ASSOCATION_PROPERTIES_KEY appears to be misspelled (likely intended as ASSOCIATION_PROPERTIES_KEY). Verify that the naming is intentional.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. packages/traceloop-sdk/src/lib/tracing/span-processor.ts:197

• Draft comment:
  In the try–catch block that parses the JSON for 'ai.prompt.messages', consider logging the error (using diag.error or similar) in the catch block to aid debugging rather than silently skipping on JSON parse failure.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. packages/traceloop-sdk/src/lib/tracing/span-processor.ts:169

• Draft comment:
  The filtering logic uses span.instrumentationScope.name to check allowed libraries. Confirm that this is the correct property per your OpenTelemetry SDK version (replacing the older instrumentationLibrary.name if needed).
• Reason this comment was not posted:
  Comment looked like it was already resolved.

5. packages/instrumentation-pinecone/test/instrumentation.test.ts:34

• Draft comment:
  There seems to be a typographical error in the constant string on this line. "pincone-instrumentation-test" might be a typo of "pinecone-instrumentation-test".
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_Xa2wIPudadDf1RBk

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed 70e2e18 in 1 minute and 45 seconds. Click for details.

• Reviewed 1029 lines of code in 35 files
• Skipped 1 files when reviewing.
• Skipped posting 12 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. packages/traceloop-sdk/test/decorators.test.ts:81

• Draft comment:
  When verifying workflow spans, you rely on immediately stringifying inputs (e.g. JSON.stringify of empty args and kwargs). Consider using helper functions or normalizing the data, since JSON field ordering (and potential formatting differences) could lead to fragile tests.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. packages/traceloop-sdk/test/decorators.test.ts:154

• Draft comment:
  Test for suppression of tracing compares spans length to zero. Confirm that the mechanism for suppressing traces reliably removes all relevant span attributes (e.g. accessing non‐existent properties returns undefined) and that the test covers all edge cases.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. packages/traceloop-sdk/test/decorators.test.ts:268

• Draft comment:
  In the method-variant workflow decorator test, the expected workflow name is constructed from instance data. To avoid hard‐coded string mismatches, consider documenting the naming convention or using computed values in assertions.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. packages/traceloop-sdk/test/decorators.test.ts:393

• Draft comment:
  There are several tests where hard‐coded token counts (e.g. '15', '333') are asserted. These magic numbers can be brittle if the underlying models’ responses change. Consider extracting these as constants or dynamically verifying ranges.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

5. packages/traceloop-sdk/test/decorators.test.ts:556

• Draft comment:
  In tests comparing association properties for parallel traces, span searches via find() assume unique messages. Although acceptable here, ensure that overlapping requests in CI won’t cause false positives.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

6. packages/traceloop-sdk/test/decorators.test.ts:631

• Draft comment:
  Tests using decorators to automatically chain workflow and task spans are quite long. Consider splitting into smaller, focused tests to ease maintenance and improve readability.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

7. packages/traceloop-sdk/test/decorators.test.ts:656

• Draft comment:
  In tests verifying Vercel AI spans, the assertions on token usage (e.g. 14, 8, 22) are hard‐coded. Consider adding comments or extracting these values for clarity, as changes in model responses may break these tests unexpectedly.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

8. packages/traceloop-sdk/test/decorators.test.ts:398

• Draft comment:
  For the test 'should not log prompts if traceContent is disabled', the assertions expect attributes to be undefined. Confirm that the instrumentation behaves consistently across environments – consider using a helper to check for absence of keys.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

9. packages/traceloop-sdk/test/decorators.test.ts:514

• Draft comment:
  In the manual LLM instrumentation test, the use of 'span.reportRequest' and 'span.reportResponse' is central. Ensure that any future changes to the interface of these methods are reflected in the tests to avoid silent breakage.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

10. packages/traceloop-sdk/test/decorators.test.ts:570

• Draft comment:
  The test verifying that association properties in parallel traces do not mix relies on find() based on prompt content. Given potential for duplication, consider a more robust method to ensure isolation between different traces.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

11. packages/traceloop-sdk/test/decorators.test.ts:630

• Draft comment:
  The tests using decorator-based chains have many assertions on deeply nested attributes. Consider adding inline comments to explain the significance of attributes such as TRACELOOP_ENTITY_INPUT and TRACELOOP_ENTITY_OUTPUT for maintainability.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

12. packages/instrumentation-pinecone/test/instrumentation.test.ts:34

• Draft comment:
  Typo: The index name string "pincone-instrumentation-test" appears to contain a typographical error. Consider correcting it to "pinecone-instrumentation-test".
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_dJH42Z60nkaOntcD

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}