Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from_data conversions in backends #2783

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

laggui
Copy link
Member

@laggui laggui commented Feb 7, 2025

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

Follow-up to #2778

Changes

With the last PR, the data conversion happens at the tensor API level. Backends should not have behave differently to handle conversions themselves.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.67%. Comparing base (6015823) to head (3e0400e).

Files with missing lines Patch % Lines
crates/burn-ndarray/src/ops/int_tensor.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2783      +/-   ##
==========================================
- Coverage   83.67%   83.67%   -0.01%     
==========================================
  Files         832      832              
  Lines      109524   109517       -7     
==========================================
- Hits        91643    91637       -6     
+ Misses      17881    17880       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant