Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better icon for trip finish #1280

Merged
merged 10 commits into from
Oct 10, 2024
Merged

Better icon for trip finish #1280

merged 10 commits into from
Oct 10, 2024

Conversation

jcardus
Copy link
Contributor

@jcardus jcardus commented Oct 10, 2024

Users sometimes get confused when looking at the trip route on the map, trying to figure out the start and end point.

I think this icon helps.

before:
Screenshot 2024-10-10 at 16 02 42

after:
Screenshot 2024-10-10 at 16 02 47

@tananaev
Copy link
Member

If we do something like this, I think we need both start and finish icons. Also make sure they are consistent in terms of padding and style.

@jcardus
Copy link
Contributor Author

jcardus commented Oct 10, 2024

I see the icons are 24x24, what do we use for the padding size?

@tananaev
Copy link
Member

I believe we use material icons as is.

add start.svg
start is success and finish is neutral
@jcardus
Copy link
Contributor Author

jcardus commented Oct 10, 2024

With 1px padding and 2 icons.

Oh I didn't kown this was material icons, I will try with those.

Screenshot 2024-10-10 at 16 57 24

@jcardus
Copy link
Contributor Author

jcardus commented Oct 10, 2024

with material icons:

Screenshot 2024-10-10 at 17 05 13

@tananaev
Copy link
Member

Looks better, but why only one has a color?

@jcardus
Copy link
Contributor Author

jcardus commented Oct 10, 2024

I wanted black, but we only have 4 options

@tananaev
Copy link
Member

tananaev commented Oct 10, 2024

There has to be a symmetry. You can't have one green and one neutral. You either make green (start) and red (stop), like a traffic light. Or you make them both neutral. Or something along those lines.

@jcardus
Copy link
Contributor Author

jcardus commented Oct 10, 2024

Green and Red:

Screenshot 2024-10-10 at 17 51 52

@tananaev tananaev merged commit a4caf0c into traccar:master Oct 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants