maximumFileSizeToCacheInBytes to 5Mb #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I say we pick a higher number, like 10MB. Also let's make it proper 10MB (10 * 1024 * 1024). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main javascript file is not being cached by the service worker be cause it passes the 4Mb limit.
The problem here is the server updates. If you update the server with a new build, the page won't open because the service worker will try to fetch and old javascript file which doesn't exist anymore.
It can be stuck forever. For it to update you have to shutdown the browser (not just refresh the page or close the tab/window) so that all clients release the active service worker.
If we cache the main javascript we won't have this problem, the page will open and the popup for the update will appear.